Re: [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf()

2018-12-07 Thread Linus Walleij
On Wed, Nov 21, 2018 at 7:12 PM Nicholas Mc Guire wrote: > kasprintf() may return NULL on failure of internal allocation thus the > assigned label is not safe if not explicitly checked. On error > mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the > (unlikely) failure case sho

Re: [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf()

2018-11-26 Thread Sean Wang
Nicholas Mc Guire 於 2018年11月21日 週三 上午10:13寫道: > > kasprintf() may return NULL on failure of internal allocation thus the > assigned label is not safe if not explicitly checked. On error > mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the > (unlikely) failure case should be fin

Re: [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf()

2018-11-22 Thread Bartosz Golaszewski
śr., 21 lis 2018 o 19:13 Nicholas Mc Guire napisał(a): > > kasprintf() may return NULL on failure of internal allocation thus the > assigned label is not safe if not explicitly checked. On error > mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the > (unlikely) failure case shou

[PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf()

2018-11-21 Thread Nicholas Mc Guire
kasprintf() may return NULL on failure of internal allocation thus the assigned label is not safe if not explicitly checked. On error mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the (unlikely) failure case should be fine here. Signed-off-by: Nicholas Mc Guire Fixes: 4ba9c3a