Re: [PATCH 1/2] hfs: fix potential refcnt problem of nls module

2018-04-18 Thread cgxu...@gmx.com
在 2018年4月19日，上午3:42，Andrew Morton 写道： > > On Tue, 17 Apr 2018 15:05:32 +0800 Chengguang Xu wrote: > >> When specifying iocharset/codepage multiple times in a mount, >> current option parsing will cause inaccurate refcount of nls >> module. Hence, call unload_nls for previous one in this case. >

Re: [PATCH 1/2] hfs: fix potential refcnt problem of nls module

2018-04-18 Thread Andrew Morton
On Tue, 17 Apr 2018 15:05:32 +0800 Chengguang Xu wrote: > When specifying iocharset/codepage multiple times in a mount, > current option parsing will cause inaccurate refcount of nls > module. Hence, call unload_nls for previous one in this case. > > ... > > --- a/fs/hfs/super.c > +++ b/fs/hfs/s

Re: [PATCH 1/2] hfs: fix potential refcnt problem of nls module

2018-04-18 Thread Viacheslav Dubeyko
On Tue, 2018-04-17 at 15:05 +0800, Chengguang Xu wrote: > When specifying iocharset/codepage multiple times in a mount, > current option parsing will cause inaccurate refcount of nls > module. Hence, call unload_nls for previous one in this case. > > Signed-off-by: Chengguang Xu Looks good. Re

[PATCH 1/2] hfs: fix potential refcnt problem of nls module

2018-04-17 Thread Chengguang Xu
When specifying iocharset/codepage multiple times in a mount, current option parsing will cause inaccurate refcount of nls module. Hence, call unload_nls for previous one in this case. Signed-off-by: Chengguang Xu --- fs/hfs/super.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)