Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-29 Thread Naoya Horiguchi
On Fri, Mar 29, 2013 at 04:09:36PM +0400, Konstantin Khlebnikov wrote: ... > hugetlb coredump filter also should be fixed in this way: > > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -1154,6 +1154,7 @@ static unsigned long vma_dump_size(struct > vm_area_struct *vma, >

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-29 Thread Michal Hocko
On Thu 28-03-13 11:42:37, Naoya Horiguchi wrote: > Currently we fail to include any data on hugepages into coredump, > because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently > introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and > mm->reserved_vm counter". This

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-29 Thread Konstantin Khlebnikov
Konstantin Khlebnikov wrote: > Naoya Horiguchi wrote: >> On Thu, Mar 28, 2013 at 09:03:16PM +0400, Konstantin Khlebnikov wrote: >>> Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-29 Thread Konstantin Khlebnikov
Konstantin Khlebnikov wrote: Naoya Horiguchi wrote: On Thu, Mar 28, 2013 at 09:03:16PM +0400, Konstantin Khlebnikov wrote: Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-29 Thread Michal Hocko
On Thu 28-03-13 11:42:37, Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 mm: kill vma flag VM_RESERVED and mm-reserved_vm counter. This looks to me

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-29 Thread Naoya Horiguchi
On Fri, Mar 29, 2013 at 04:09:36PM +0400, Konstantin Khlebnikov wrote: ... hugetlb coredump filter also should be fixed in this way: --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1154,6 +1154,7 @@ static unsigned long vma_dump_size(struct vm_area_struct *vma,

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Konstantin Khlebnikov
Naoya Horiguchi wrote: > On Thu, Mar 28, 2013 at 09:03:16PM +0400, Konstantin Khlebnikov wrote: >> Naoya Horiguchi wrote: >>> Currently we fail to include any data on hugepages into coredump, >>> because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently >>> introduced by commit

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Naoya Horiguchi
On Thu, Mar 28, 2013 at 07:39:01PM +, Ben Hutchings wrote: > On Thu, Mar 28, 2013 at 12:04:29PM -0400, Naoya Horiguchi wrote: > [...] > > I guess you mean this patch violates one/both of these rules: > > > > - It must fix a problem that causes a build error (but not for things > >marked

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Ben Hutchings
On Thu, Mar 28, 2013 at 12:04:29PM -0400, Naoya Horiguchi wrote: [...] > I guess you mean this patch violates one/both of these rules: > > - It must fix a problem that causes a build error (but not for things >marked CONFIG_BROKEN), an oops, a hang, data corruption, a real >security

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Naoya Horiguchi
On Thu, Mar 28, 2013 at 09:03:16PM +0400, Konstantin Khlebnikov wrote: > Naoya Horiguchi wrote: > >Currently we fail to include any data on hugepages into coredump, > >because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently > >introduced by commit 314e51b98 "mm: kill vma flag

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Konstantin Khlebnikov
Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and mm->reserved_vm counter". This looks to me a serious regression, so

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Naoya Horiguchi
On Thu, Mar 28, 2013 at 08:51:09AM -0700, Greg KH wrote: > On Thu, Mar 28, 2013 at 11:42:37AM -0400, Naoya Horiguchi wrote: > > Currently we fail to include any data on hugepages into coredump, > > because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently > > introduced by commit

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 11:42:37AM -0400, Naoya Horiguchi wrote: > Currently we fail to include any data on hugepages into coredump, > because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently > introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and > mm->reserved_vm

[PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Naoya Horiguchi
Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and mm->reserved_vm counter". This looks to me a serious regression, so let's fix it.

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Naoya Horiguchi
On Thu, Mar 28, 2013 at 09:03:16PM +0400, Konstantin Khlebnikov wrote: Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 mm: kill vma flag VM_RESERVED

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Ben Hutchings
On Thu, Mar 28, 2013 at 12:04:29PM -0400, Naoya Horiguchi wrote: [...] I guess you mean this patch violates one/both of these rules: - It must fix a problem that causes a build error (but not for things marked CONFIG_BROKEN), an oops, a hang, data corruption, a real security issue, or

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Naoya Horiguchi
On Thu, Mar 28, 2013 at 07:39:01PM +, Ben Hutchings wrote: On Thu, Mar 28, 2013 at 12:04:29PM -0400, Naoya Horiguchi wrote: [...] I guess you mean this patch violates one/both of these rules: - It must fix a problem that causes a build error (but not for things marked

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Konstantin Khlebnikov
Naoya Horiguchi wrote: On Thu, Mar 28, 2013 at 09:03:16PM +0400, Konstantin Khlebnikov wrote: Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 mm:

[PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Naoya Horiguchi
Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 mm: kill vma flag VM_RESERVED and mm-reserved_vm counter. This looks to me a serious regression, so let's fix it.

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 11:42:37AM -0400, Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 mm: kill vma flag VM_RESERVED and mm-reserved_vm counter.

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Naoya Horiguchi
On Thu, Mar 28, 2013 at 08:51:09AM -0700, Greg KH wrote: On Thu, Mar 28, 2013 at 11:42:37AM -0400, Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit

Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB)

2013-03-28 Thread Konstantin Khlebnikov
Naoya Horiguchi wrote: Currently we fail to include any data on hugepages into coredump, because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently introduced by commit 314e51b98 mm: kill vma flag VM_RESERVED and mm-reserved_vm counter. This looks to me a serious regression, so