Re: [PATCH 1/2] hw_random: mxc-rnga: Adapt clocks to new i.mx clock framework

2012-07-27 Thread Fabio Estevam
On Mon, Jul 9, 2012 at 4:41 AM, Sascha Hauer wrote: > Uhh, that's a driver bug that should be fixed. Although right now there > is no reference counting for clocks, the driver should keep the clk > internally instead of simply calling clk_get whenever it needs access to > a clk. Yes, I just

Re: [PATCH 1/2] hw_random: mxc-rnga: Adapt clocks to new i.mx clock framework

2012-07-27 Thread Fabio Estevam
On Mon, Jul 9, 2012 at 4:41 AM, Sascha Hauer s.ha...@pengutronix.de wrote: Uhh, that's a driver bug that should be fixed. Although right now there is no reference counting for clocks, the driver should keep the clk internally instead of simply calling clk_get whenever it needs access to a

Re: [PATCH 1/2] hw_random: mxc-rnga: Adapt clocks to new i.mx clock framework

2012-07-09 Thread Sascha Hauer
On Fri, Jul 06, 2012 at 05:20:19PM -0300, Fabio Estevam wrote: > Cc: Theodore Ts'o > Cc: Herbert Xu > Cc: > Signed-off-by: Fabio Estevam > --- > drivers/char/hw_random/mxc-rnga.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 1/2] hw_random: mxc-rnga: Adapt clocks to new i.mx clock framework

2012-07-09 Thread Sascha Hauer
On Fri, Jul 06, 2012 at 05:20:19PM -0300, Fabio Estevam wrote: Cc: Theodore Ts'o ty...@mit.edu Cc: Herbert Xu herb...@gondor.apana.org.au Cc: linux-kernel@vger.kernel.org Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/char/hw_random/mxc-rnga.c |8 1

[PATCH 1/2] hw_random: mxc-rnga: Adapt clocks to new i.mx clock framework

2012-07-06 Thread Fabio Estevam
Adapt clocks to the new i.mx clock framework and fix the following warning: [ cut here ] WARNING: at drivers/clk/clk.c:511 __clk_enable+0x9c/0xac() Modules linked in:

[PATCH 1/2] hw_random: mxc-rnga: Adapt clocks to new i.mx clock framework

2012-07-06 Thread Fabio Estevam
Adapt clocks to the new i.mx clock framework and fix the following warning: [ cut here ] WARNING: at drivers/clk/clk.c:511 __clk_enable+0x9c/0xac() Modules linked in: