Re: [PATCH 1/2] hwrng: OMAP3 ROM Random Number Generator support

2013-09-18 Thread Aaro Koskinen
Hi, On Wed, Sep 18, 2013 at 10:05:56PM +0200, Pali Rohár wrote: > + if (IS_ERR(rng_clk)) { > + printk(KERN_ERR "%s: unable to get RNG clock\n", > +omap3_rom_rng_name); > + return IS_ERR(rng_clk); This should be PTR_ERR(). A. -- To unsubscribe from

Re: [PATCH 1/2] hwrng: OMAP3 ROM Random Number Generator support

2013-09-18 Thread Joe Perches
On Wed, 2013-09-18 at 22:05 +0200, Pali Rohár wrote: > This driver provides kernel-side support for the Random Number > Generator hardware found on OMAP34xx processors. [] > diff --git a/drivers/char/hw_random/omap3-rom-rng.c > b/drivers/char/hw_random/omap3-rom-rng.c trivial note: It produces

[PATCH 1/2] hwrng: OMAP3 ROM Random Number Generator support

2013-09-18 Thread Pali Rohár
This driver provides kernel-side support for the Random Number Generator hardware found on OMAP34xx processors. Signed-off-by: Pali Rohár Signed-off-by: Juha Yrjola --- drivers/char/hw_random/Kconfig | 13 +++ drivers/char/hw_random/Makefile|1 + drivers/char/hw_random/oma