Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent

2015-09-09 Thread Grygorii Strashko
On 09/09/2015 11:53 AM, Thomas Gleixner wrote: On Wed, 9 Sep 2015, Grygorii Strashko wrote: On 09/08/2015 11:03 PM, Thomas Gleixner wrote: So, yes a seperate locking class for that intc trainwreck is probably required. Just as an option, May be we can proceed with patch: [PATCH v2 2/6] genir

Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent

2015-09-09 Thread Thomas Gleixner
On Wed, 9 Sep 2015, Grygorii Strashko wrote: > On 09/08/2015 11:03 PM, Thomas Gleixner wrote: > > So, yes a seperate locking class for that intc trainwreck is probably > > required. > > > > Just as an option, May be we can proceed with patch: > [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent i

Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent

2015-09-09 Thread Grygorii Strashko
Hi, On 09/08/2015 11:03 PM, Thomas Gleixner wrote: > On Tue, 8 Sep 2015, Geert Uytterhoeven wrote: --- a/drivers/irqchip/irq-renesas-intc-irqpin.c +++ b/drivers/irqchip/irq-renesas-intc-irqpin.c @@ -283,6 +283,9 @@ static int intc_irqpin_irq_set_type(struct irq_data *d, unsign

Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent

2015-09-08 Thread Thomas Gleixner
On Tue, 8 Sep 2015, Geert Uytterhoeven wrote: > >> --- a/drivers/irqchip/irq-renesas-intc-irqpin.c > >> +++ b/drivers/irqchip/irq-renesas-intc-irqpin.c > >> @@ -283,6 +283,9 @@ static int intc_irqpin_irq_set_type(struct irq_data > >> *d, unsigned int type) > >> static int intc_irqpin_irq_set_wake

Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent

2015-09-08 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Sep 8, 2015 at 9:05 PM, Thomas Gleixner wrote: > On Tue, 8 Sep 2015, Geert Uytterhoeven wrote: >> The renesas-intc-irqpin interrupt controller is cascaded to the GIC, but >> its driver doesn't propagate wake-up settings to the parent interrupt >> controller. >> >> Since commit

Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent

2015-09-08 Thread Thomas Gleixner
On Tue, 8 Sep 2015, Geert Uytterhoeven wrote: > The renesas-intc-irqpin interrupt controller is cascaded to the GIC, but > its driver doesn't propagate wake-up settings to the parent interrupt > controller. > > Since commit aec89ef72ba6c944 ("irqchip/gic: Enable SKIP_SET_WAKE and > MASK_ON_SUSPEND

[PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up settings to parent

2015-09-08 Thread Geert Uytterhoeven
The renesas-intc-irqpin interrupt controller is cascaded to the GIC, but its driver doesn't propagate wake-up settings to the parent interrupt controller. Since commit aec89ef72ba6c944 ("irqchip/gic: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND"), the GIC driver masks interrupts during suspend, and wa