Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-13 Thread Stefan Hengelein
Hi Gregory, 2015-04-13 3:06 GMT+02:00 Gregory Fong : > Hi Paul and Stefan, > > Thanks for taking a look at this. I think Stefan has touched upon why > he thinks this change might (at least partially) make sense, but let > me now try to explain the rationale behind this patch better than I > did in

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-13 Thread Stefan Hengelein
>> > The search facility shows the first one that is found, you see the >> > complicated depends on but i think the text shown might not be >> > explicit enough to clarify you don't need to satisfy these complicated >> > conditions to actually choose a value. >> > >> >> Well, the thing is, you do n

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-13 Thread Paul Bolle
Hi Gregory, On Sun, 2015-04-12 at 18:06 -0700, Gregory Fong wrote: > On Sun, Apr 12, 2015 at 8:02 AM, Stefan Hengelein > > If you have a look at the definitions, lib/Kconfig.debug is included > > before FRAME_POINTER is defined in m32r and the output in the search > > facility looks indeed broken

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-12 Thread Gregory Fong
Hi Paul and Stefan, Thanks for taking a look at this. I think Stefan has touched upon why he thinks this change might (at least partially) make sense, but let me now try to explain the rationale behind this patch better than I did in the commit message. On Sun, Apr 12, 2015 at 8:02 AM, Stefan He

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-12 Thread Stefan Hengelein
> Let's focus, for example, on m32r and FRAME_POINTER. The m32r entry for > that symbol reads: > config FRAME_POINTER > bool "Compile the kernel with frame pointers" > help > If you say Y here [...] > > 0) If one is building for m32r is that

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Paul Bolle
On Sat, 2015-04-11 at 23:46 +0200, Stefan Hengelein wrote: > 2015-04-11 22:23 GMT+02:00 Paul Bolle : > > That's a NAK to this patch, isn't it? > > That's not for me to decide. Maybe I missed something! > But I wouldn't merge it in the current state. Thanks. That's all I needed to hear. > > I'd r

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Stefan Hengelein
2015-04-11 22:23 GMT+02:00 Paul Bolle : > On Sat, 2015-04-11 at 21:58 +0200, Stefan Hengelein wrote: >> 2015-04-11 20:56 GMT+02:00 Paul Bolle : >> > On Sat, 2015-04-11 at 18:36 +0200, Stefan Hengelein wrote: >> What i meant to say, you won't get a prompt (or for mconf, won't see >> it in the menu)

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Paul Bolle
On Sat, 2015-04-11 at 21:58 +0200, Stefan Hengelein wrote: > 2015-04-11 20:56 GMT+02:00 Paul Bolle : > > On Sat, 2015-04-11 at 18:36 +0200, Stefan Hengelein wrote: > What i meant to say, you won't get a prompt (or for mconf, won't see > it in the menu) if THUMB2_KERNEL is disabled, FRAME_POINTER wi

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Stefan Hengelein
2015-04-11 20:56 GMT+02:00 Paul Bolle : > On Sat, 2015-04-11 at 18:36 +0200, Stefan Hengelein wrote: >> If you're reading the dependency list as "what do i have to enable to >> be able to choose a value for FRAME_POINTER" and think, THUMB2_KERNEL >> would be a good choice to leave disabled, you're

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Paul Bolle
On Sat, 2015-04-11 at 18:36 +0200, Stefan Hengelein wrote: > If you're reading the dependency list as "what do i have to enable to > be able to choose a value for FRAME_POINTER" and think, THUMB2_KERNEL > would be a good choice to leave disabled, you're going to have a bad > time. > (The second def

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-11 Thread Stefan Hengelein
2015-04-10 23:25 GMT+02:00 Paul Bolle : > [Removed Yann. Added the people that I hope might actually understand > what this is all about.] > > On Wed, 2015-04-08 at 16:56 -0700, Gregory Fong wrote: >> get_symbol_str() was assuming that symbols would only have a single >> property for the purpose of

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-10 Thread Paul Bolle
[Removed Yann. Added the people that I hope might actually understand what this is all about.] On Wed, 2015-04-08 at 16:56 -0700, Gregory Fong wrote: > get_symbol_str() was assuming that symbols would only have a single > property for the purpose of printing define and depends information. > This

Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-08 Thread Gregory Fong
I accidentally marked this as patch 1/2, but this is the only patch. Sorry for the confusion. On Wed, Apr 8, 2015 at 4:56 PM, Gregory Fong wrote: > get_symbol_str() was assuming that symbols would only have a single > property for the purpose of printing define and depends information. > This is

[PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols

2015-04-08 Thread Gregory Fong
get_symbol_str() was assuming that symbols would only have a single property for the purpose of printing define and depends information. This is not true, and one current example is FRAME_POINTER which is both in lib/Kconfig.debug and arch/arm/Kconfig.debug. In order to print out the correct Defin