Re: [PATCH 1/2] kill_something_info: misc cleanups

2006-12-18 Thread Oleg Nesterov
On 12/18, Eric W. Biederman wrote: > > Oleg Nesterov <[EMAIL PROTECTED]> writes: > > > Btw, de_thread() already takes care about multithread init, but > > get_signal_to_deliver() does not: > > > > if (current == child_reaper(current)) > > continue; > > Probably just: current->grou

Re: [PATCH 1/2] kill_something_info: misc cleanups

2006-12-18 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > On 12/17, Eric W. Biederman wrote: >> >> I am sitting here wondering why we bother to ignore init, as init >> is protected from all signals it doesn't explicitly setup a signal >> handler for. >> ... >> So I believe we can delete we

Re: [PATCH 1/2] kill_something_info: misc cleanups

2006-12-17 Thread Oleg Nesterov
On 12/17, Eric W. Biederman wrote: > > I am sitting here wondering why we bother to ignore init, as init > is protected from all signals it doesn't explicitly setup a signal > handler for. > ... > So I believe we can delete we can delete > the is_init check entirely without ch

Re: [PATCH 1/2] kill_something_info: misc cleanups

2006-12-17 Thread Eric W. Biederman
Christoph Hellwig <[EMAIL PROTECTED]> writes: > On Sat, Dec 16, 2006 at 11:05:10PM +0300, Oleg Nesterov wrote: >> static int kill_something_info(int sig, struct siginfo *info, int pid) >> { >> int ret; >> + >> +rcu_read_lock(); >> +if (pid > 0) { >> +ret = kill_pid_info(

Re: [PATCH 1/2] kill_something_info: misc cleanups

2006-12-17 Thread Christoph Hellwig
On Sat, Dec 16, 2006 at 11:05:10PM +0300, Oleg Nesterov wrote: > static int kill_something_info(int sig, struct siginfo *info, int pid) > { > int ret; > + > + rcu_read_lock(); > + if (pid > 0) { > + ret = kill_pid_info(sig, info, find_pid(pid)); > + } else if (pid ==

Re: [PATCH 1/2] kill_something_info: misc cleanups

2006-12-16 Thread Eric W. Biederman
I'm CC'ing the containers list these namespaces are what it is setup to talk about. Oleg Nesterov <[EMAIL PROTECTED]> writes: > On 12/16, Eric W. Biederman wrote: >> >> Oleg Nesterov <[EMAIL PROTECTED]> writes: >> >> > On top of >> >signal-rewrite-kill_something_info-so-it-uses-newer-helper

Re: [PATCH 1/2] kill_something_info: misc cleanups

2006-12-16 Thread Oleg Nesterov
On 12/16, Eric W. Biederman wrote: > > Oleg Nesterov <[EMAIL PROTECTED]> writes: > > > On top of > > signal-rewrite-kill_something_info-so-it-uses-newer-helpers.patch > > > > - Factor out sending PIDTYPE_PGID wide signals. > > > > - Use is_init(p) instead of "p->pid > 1". We don't hash idle th

Re: [PATCH 1/2] kill_something_info: misc cleanups

2006-12-16 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > On top of > signal-rewrite-kill_something_info-so-it-uses-newer-helpers.patch > > - Factor out sending PIDTYPE_PGID wide signals. > > - Use is_init(p) instead of "p->pid > 1". We don't hash idle threads anymore, > no need to worry about p->pid ==

[PATCH 1/2] kill_something_info: misc cleanups

2006-12-16 Thread Oleg Nesterov
On top of signal-rewrite-kill_something_info-so-it-uses-newer-helpers.patch - Factor out sending PIDTYPE_PGID wide signals. - Use is_init(p) instead of "p->pid > 1". We don't hash idle threads anymore, no need to worry about p->pid == 0. - Use "p != current->group_leader" instead of "p