As J. Bruce Fields pointed out, kstrto* is
currently lacking kerneldoc comments.
This patch adds kerneldoc comments to common variants of kstrto*:
kstrto(u)l, kstrto(u)ll and kstrto(u)int.
Cc: J. Bruce Fields
Signed-off-by: Eldad Zack
---
v2: includes typo fix from Joe Perches ,
added details
As J. Bruce Fields bfie...@fieldses.org pointed out, kstrto* is
currently lacking kerneldoc comments.
This patch adds kerneldoc comments to common variants of kstrto*:
kstrto(u)l, kstrto(u)ll and kstrto(u)int.
Cc: J. Bruce Fields bfie...@fieldses.org
Signed-off-by: Eldad Zack
On Thu, 12 Jul 2012, J. Bruce Fields wrote:
> On Fri, Jul 13, 2012 at 12:09:37AM +0200, Eldad Zack wrote:
> >
> > On Thu, 12 Jul 2012, J. Bruce Fields wrote:
> > I am not sure if I understand _parse_integer correctly (which is called
> > to do the actual parsing and has a very nice comment to
On Fri, Jul 13, 2012 at 12:09:37AM +0200, Eldad Zack wrote:
>
> On Thu, 12 Jul 2012, J. Bruce Fields wrote:
> > On Thu, Jul 12, 2012 at 10:53:13PM +0200, Eldad Zack wrote:
> > > +/**
> > > + * kstrtoul - convert a string to an unsigned long
> >
> > Also, is it worth mentioning that the number is
On Thu, 12 Jul 2012, J. Bruce Fields wrote:
> On Thu, Jul 12, 2012 at 10:53:13PM +0200, Eldad Zack wrote:
> > +/**
> > + * kstrtoul - convert a string to an unsigned long
>
> Also, is it worth mentioning that the number is required to be followed
> by a string or newline?
I am not sure if I
On Thu, Jul 12, 2012 at 10:53:13PM +0200, Eldad Zack wrote:
> As J. Bruce Fields pointed out, kstrto* is
> currently lacking kerneldoc comments.
> This patch adds kerneldoc comments to common variants of kstrto*:
> kstrto(u)l, kstrto(u)ll and kstrto(u)int.
>
> Cc: J. Bruce Fields
>
On 07/12/12 14:17, Stephen Boyd wrote:
> On 07/12/12 13:53, Eldad Zack wrote:
>> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
>> index e07f5e0..582df0f 100644
>> --- a/include/linux/kernel.h
>> +++ b/include/linux/kernel.h
>> @@ -220,6 +220,16 @@ int __must_check _kstrtol(const
On 07/12/12 13:53, Eldad Zack wrote:
>
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
> index e07f5e0..582df0f 100644
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -220,6 +220,16 @@ int __must_check _kstrtol(const char *s, unsigned int
> base, long *res);
>
As J. Bruce Fields pointed out, kstrto* is
currently lacking kerneldoc comments.
This patch adds kerneldoc comments to common variants of kstrto*:
kstrto(u)l, kstrto(u)ll and kstrto(u)int.
Cc: J. Bruce Fields
Signed-off-by: Eldad Zack
---
include/linux/kernel.h | 36
As J. Bruce Fields bfie...@fieldses.org pointed out, kstrto* is
currently lacking kerneldoc comments.
This patch adds kerneldoc comments to common variants of kstrto*:
kstrto(u)l, kstrto(u)ll and kstrto(u)int.
Cc: J. Bruce Fields bfie...@fieldses.org
Signed-off-by: Eldad Zack
On 07/12/12 13:53, Eldad Zack wrote:
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index e07f5e0..582df0f 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -220,6 +220,16 @@ int __must_check _kstrtol(const char *s, unsigned int
base, long *res);
int
On 07/12/12 14:17, Stephen Boyd wrote:
On 07/12/12 13:53, Eldad Zack wrote:
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index e07f5e0..582df0f 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -220,6 +220,16 @@ int __must_check _kstrtol(const char *s,
On Thu, Jul 12, 2012 at 10:53:13PM +0200, Eldad Zack wrote:
As J. Bruce Fields bfie...@fieldses.org pointed out, kstrto* is
currently lacking kerneldoc comments.
This patch adds kerneldoc comments to common variants of kstrto*:
kstrto(u)l, kstrto(u)ll and kstrto(u)int.
Cc: J. Bruce Fields
On Thu, 12 Jul 2012, J. Bruce Fields wrote:
On Thu, Jul 12, 2012 at 10:53:13PM +0200, Eldad Zack wrote:
+/**
+ * kstrtoul - convert a string to an unsigned long
Also, is it worth mentioning that the number is required to be followed
by a string or newline?
I am not sure if I understand
On Fri, Jul 13, 2012 at 12:09:37AM +0200, Eldad Zack wrote:
On Thu, 12 Jul 2012, J. Bruce Fields wrote:
On Thu, Jul 12, 2012 at 10:53:13PM +0200, Eldad Zack wrote:
+/**
+ * kstrtoul - convert a string to an unsigned long
Also, is it worth mentioning that the number is required to
On Thu, 12 Jul 2012, J. Bruce Fields wrote:
On Fri, Jul 13, 2012 at 12:09:37AM +0200, Eldad Zack wrote:
On Thu, 12 Jul 2012, J. Bruce Fields wrote:
I am not sure if I understand _parse_integer correctly (which is called
to do the actual parsing and has a very nice comment to it) - but
16 matches
Mail list logo