Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-23 Thread Benoit Cousson
On 23/10/2013 10:19, Tony Lindgren wrote: * Bryan Wu [131022 10:47]: On Tue, Oct 22, 2013 at 10:37 AM, Tony Lindgren wrote: * Bryan Wu [131022 10:23]: On Tue, Oct 22, 2013 at 10:06 AM, Tony Lindgren wrote: * Sebastian Reichel [131022 06:02]: This patch moves the handling of the chip's e

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-23 Thread Tony Lindgren
* Bryan Wu [131022 10:47]: > On Tue, Oct 22, 2013 at 10:37 AM, Tony Lindgren wrote: > > * Bryan Wu [131022 10:23]: > >> On Tue, Oct 22, 2013 at 10:06 AM, Tony Lindgren wrote: > >> > * Sebastian Reichel [131022 06:02]: > >> >> This patch moves the handling of the chip's enable pin from the boar

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Bryan Wu
On Tue, Oct 22, 2013 at 10:37 AM, Tony Lindgren wrote: > * Bryan Wu [131022 10:23]: >> On Tue, Oct 22, 2013 at 10:06 AM, Tony Lindgren wrote: >> > * Sebastian Reichel [131022 06:02]: >> >> This patch moves the handling of the chip's enable pin from the board >> >> code into the driver. It also

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Tony Lindgren
* Bryan Wu [131022 10:23]: > On Tue, Oct 22, 2013 at 10:06 AM, Tony Lindgren wrote: > > * Sebastian Reichel [131022 06:02]: > >> This patch moves the handling of the chip's enable pin from the board > >> code into the driver. It also updates all board-code files using the > >> driver to incorpor

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Bryan Wu
On Tue, Oct 22, 2013 at 10:06 AM, Tony Lindgren wrote: > * Sebastian Reichel [131022 06:02]: >> This patch moves the handling of the chip's enable pin from the board >> code into the driver. It also updates all board-code files using the >> driver to incorporate this change. >> >> This is needed

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Tony Lindgren
* Sebastian Reichel [131022 06:02]: > This patch moves the handling of the chip's enable pin from the board > code into the driver. It also updates all board-code files using the > driver to incorporate this change. > > This is needed for device tree support of the enable pin. This seems safe to

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Linus Walleij
On Tue, Oct 22, 2013 at 6:57 PM, Linus Walleij wrote: > BTW: should we disable the GPIO when remove()ing the module? > This is a topic of another patch but... Bah forget this stupid comment, I misread it, obviously you're doing this. Yours, Linus Walleij -- To unsubscribe from this list: send t

Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Linus Walleij
On Tue, Oct 22, 2013 at 3:01 PM, Sebastian Reichel wrote: > This patch moves the handling of the chip's enable pin from the board > code into the driver. It also updates all board-code files using the > driver to incorporate this change. > > This is needed for device tree support of the enable pi

[PATCH 1/2] leds: lp55xx: handle enable pin in driver

2013-10-22 Thread Sebastian Reichel
This patch moves the handling of the chip's enable pin from the board code into the driver. It also updates all board-code files using the driver to incorporate this change. This is needed for device tree support of the enable pin. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/le