Re: [PATCH 1/2] lib/bpf hashmap: increase portability

2020-05-06 Thread Ian Rogers
On Wed, May 6, 2020 at 2:56 PM Andrii Nakryiko wrote: > > On Wed, May 6, 2020 at 2:47 PM Ian Rogers wrote: > > > > On Wed, May 6, 2020 at 2:33 PM Andrii Nakryiko > > wrote: > > > > > > On Wed, May 6, 2020 at 1:54 PM Ian Rogers wrote: > > > > > > > > Don't include libbpf_internal.h as it is unus

Re: [PATCH 1/2] lib/bpf hashmap: increase portability

2020-05-06 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 2:47 PM Ian Rogers wrote: > > On Wed, May 6, 2020 at 2:33 PM Andrii Nakryiko > wrote: > > > > On Wed, May 6, 2020 at 1:54 PM Ian Rogers wrote: > > > > > > Don't include libbpf_internal.h as it is unused and has conflicting > > > definitions, for example, with tools/perf/ut

Re: [PATCH 1/2] lib/bpf hashmap: increase portability

2020-05-06 Thread Ian Rogers
On Wed, May 6, 2020 at 2:33 PM Andrii Nakryiko wrote: > > On Wed, May 6, 2020 at 1:54 PM Ian Rogers wrote: > > > > Don't include libbpf_internal.h as it is unused and has conflicting > > definitions, for example, with tools/perf/util/debug.h. > > Fix a non-glibc include path. > > > > Signed-off-b

Re: [PATCH 1/2] lib/bpf hashmap: increase portability

2020-05-06 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 1:54 PM Ian Rogers wrote: > > Don't include libbpf_internal.h as it is unused and has conflicting > definitions, for example, with tools/perf/util/debug.h. > Fix a non-glibc include path. > > Signed-off-by: Ian Rogers > --- > tools/lib/bpf/hashmap.h | 3 +-- > 1 file chang

[PATCH 1/2] lib/bpf hashmap: increase portability

2020-05-06 Thread Ian Rogers
Don't include libbpf_internal.h as it is unused and has conflicting definitions, for example, with tools/perf/util/debug.h. Fix a non-glibc include path. Signed-off-by: Ian Rogers --- tools/lib/bpf/hashmap.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/lib/bpf/hash