Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-05-08 Thread Ardelean, Alexandru
On Mon, 2019-05-06 at 17:46 +0300, andriy.shevche...@linux.intel.com wrote: > [External] > > > On Mon, May 06, 2019 at 04:45:43PM +0300, Alexandru Ardelean wrote: > > On Fri, Apr 26, 2019 at 5:27 PM andriy.shevche...@linux.intel.com > > wrote: > > > > > > On Fri, Apr 26, 2019 at 12:29:11PM

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-05-06 Thread andriy.shevche...@linux.intel.com
On Mon, May 06, 2019 at 04:45:43PM +0300, Alexandru Ardelean wrote: > On Fri, Apr 26, 2019 at 5:27 PM andriy.shevche...@linux.intel.com > wrote: > > > > On Fri, Apr 26, 2019 at 12:29:11PM +0300, Alexandru Ardelean wrote: > > > > > Hmm, I actually did not give much thought to that -1. > > > I'll

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-05-06 Thread Alexandru Ardelean
On Fri, Apr 26, 2019 at 5:27 PM andriy.shevche...@linux.intel.com wrote: > > On Fri, Apr 26, 2019 at 12:29:11PM +0300, Alexandru Ardelean wrote: > > > Hmm, I actually did not give much thought to that -1. > > I'll check into this and see about a V3. > > It may make more sense to just fix the

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-26 Thread andriy.shevche...@linux.intel.com
On Fri, Apr 26, 2019 at 12:29:11PM +0300, Alexandru Ardelean wrote: > Hmm, I actually did not give much thought to that -1. > I'll check into this and see about a V3. > It may make more sense to just fix the original > `__sysfs_match_string()`, but I'll need to go through the users of > this

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-26 Thread Alexandru Ardelean
On Thu, Apr 25, 2019 at 10:38 PM gre...@linuxfoundation.org wrote: > > On Wed, Apr 24, 2019 at 01:34:55PM +0100, Jonathan Cameron wrote: > > On Tue, 23 Apr 2019 06:38:44 + > > "Ardelean, Alexandru" wrote: > > > > > On Mon, 2019-04-22 at 23:06 +0200, Greg KH wrote: > > > > > > > > > > > > On

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-25 Thread gre...@linuxfoundation.org
On Wed, Apr 24, 2019 at 01:34:55PM +0100, Jonathan Cameron wrote: > On Tue, 23 Apr 2019 06:38:44 + > "Ardelean, Alexandru" wrote: > > > On Mon, 2019-04-22 at 23:06 +0200, Greg KH wrote: > > > > > > > > > On Mon, Apr 22, 2019 at 11:32:56AM +0300, Alexandru Ardelean wrote: > > > > This

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-24 Thread Jonathan Cameron
On Tue, 23 Apr 2019 06:38:44 + "Ardelean, Alexandru" wrote: > On Mon, 2019-04-22 at 23:06 +0200, Greg KH wrote: > > > > > > On Mon, Apr 22, 2019 at 11:32:56AM +0300, Alexandru Ardelean wrote: > > > This helper is similar to __sysfs_match_string() with the exception > > > that it > > >

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-23 Thread Ardelean, Alexandru
On Mon, 2019-04-22 at 23:06 +0200, Greg KH wrote: > > > On Mon, Apr 22, 2019 at 11:32:56AM +0300, Alexandru Ardelean wrote: > > This helper is similar to __sysfs_match_string() with the exception > > that it > > ignores NULL elements within the array. > > sysfs is "one value per file", why are

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-22 Thread Greg KH
On Mon, Apr 22, 2019 at 11:32:56AM +0300, Alexandru Ardelean wrote: > This helper is similar to __sysfs_match_string() with the exception that it > ignores NULL elements within the array. sysfs is "one value per file", why are you trying to write multiple things on a single line to a single sysfs

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-22 Thread Ardelean, Alexandru
On Mon, 2019-04-22 at 11:37 +0100, Jonathan Cameron wrote: > [External] > > > On Mon, 22 Apr 2019 11:32:56 +0300 > Alexandru Ardelean wrote: > > > This helper is similar to __sysfs_match_string() with the exception > > that it > > ignores NULL elements within the array. > > It takes an extra

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-22 Thread Jonathan Cameron
On Mon, 22 Apr 2019 11:32:56 +0300 Alexandru Ardelean wrote: > This helper is similar to __sysfs_match_string() with the exception that it > ignores NULL elements within the array. > It takes an extra parameter (called `gaps`) which when true will ignore > the NULL elements. When false, this

[PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-22 Thread Alexandru Ardelean
This helper is similar to __sysfs_match_string() with the exception that it ignores NULL elements within the array. It takes an extra parameter (called `gaps`) which when true will ignore the NULL elements. When false, this function behaves exactly like `__sysfs_match_string()`. Signed-off-by: