Re: [PATCH 1/2] libata: add ledtrig support

2018-09-20 Thread Daniel Golle
Hi Pavel, On Fri, Sep 21, 2018 at 12:04:49AM +0200, Pavel Machek wrote: > Hi! > > > > > +#ifdef CONFIG_ATA_LEDS > > > > + /* register LED triggers for all ports */ > > > > + for (i = 0; i < host->n_ports; i++) { > > > > + if (unlikely(!host->ports[i]->ledtrig)) > > > > +

Re: [PATCH 1/2] libata: add ledtrig support

2018-09-20 Thread Pavel Machek
Hi! > > > +#ifdef CONFIG_ATA_LEDS > > > + /* register LED triggers for all ports */ > > > + for (i = 0; i < host->n_ports; i++) { > > > + if (unlikely(!host->ports[i]->ledtrig)) > > > + continue; > > > + > > > + snprintf(host->ports[i]->ledtrig_name, > > > +

Re: [PATCH 1/2] libata: add ledtrig support

2018-09-20 Thread Aditya Prayoga
Hi Andrew, thank you for your feedback. It seem i also need to resolve the issue reported by kbuild test robot. Aditya

Re: [PATCH 1/2] libata: add ledtrig support

2018-09-20 Thread Daniel Golle
Hi! On Thu, Sep 20, 2018 at 09:23:54AM +0200, Pavel Machek wrote: > Hi! > > > +#ifdef CONFIG_ATA_LEDS > > + /* register LED triggers for all ports */ > > + for (i = 0; i < host->n_ports; i++) { > > + if (unlikely(!host->ports[i]->ledtrig)) > > + continue; > > + > >

Re: [PATCH 1/2] libata: add ledtrig support

2018-09-20 Thread Pavel Machek
Hi! > +#ifdef CONFIG_ATA_LEDS > + /* register LED triggers for all ports */ > + for (i = 0; i < host->n_ports; i++) { > + if (unlikely(!host->ports[i]->ledtrig)) > + continue; > + > + snprintf(host->ports[i]->ledtrig_name, > +

Re: [PATCH 1/2] libata: add ledtrig support

2018-09-19 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on block/for-next] [also build test WARNING on v4.19-rc4 next-20180919] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-

Re: [PATCH 1/2] libata: add ledtrig support

2018-09-19 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v4.19-rc4 next-20180919] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 1/2] libata: add ledtrig support

2018-09-19 Thread Andrew Lunn
On Wed, Sep 19, 2018 at 11:45:29AM +0800, Aditya Prayoga wrote: > From: Daniel Golle > > This adds a LED trigger for each ATA port indicating disk activity. > > As this is needed only on specific platforms (NAS SoCs and such), > these platforms should define ARCH_WANTS_LIBATA_LEDS if there > are

[PATCH 1/2] libata: add ledtrig support

2018-09-18 Thread Aditya Prayoga
From: Daniel Golle This adds a LED trigger for each ATA port indicating disk activity. As this is needed only on specific platforms (NAS SoCs and such), these platforms should define ARCH_WANTS_LIBATA_LEDS if there are boards with LED(s) intended to indicate ATA disk activity and need the OS to