Re: [PATCH 1/2] libsas: Don't process sas events in static works

2017-05-22 Thread wangyijing
>> > > I have seen this scenario on our development board when we have a bad > physical cable connection - the PHY continually goes up and down in a loop. > > So, in this regard, it is worth safeguarding against this scenario. OK, I will reconsider this case. Thanks! Yijing. > > John > >

Re: [PATCH 1/2] libsas: Don't process sas events in static works

2017-05-22 Thread John Garry
On 22/05/2017 06:54, wangyijing wrote: I also think for safety this should use a mempool that guarantees that > events can continue to be processed under system memory pressure. What I am worried about is it's would still fail if the mempool is used empty during memory pressure. > Also, have

Re: [PATCH 1/2] libsas: Don't process sas events in static works

2017-05-21 Thread wangyijing
Hi Dan, thanks for your review and comments! 在 2017/5/21 11:44, Dan Williams 写道: > On Fri, May 19, 2017 at 11:39 PM, Yijing Wang wrote: >> Now libsas hotplug work is static, LLDD driver queue >> the hotplug work into shost->work_q. If LLDD driver >> burst post lots hotplug events to libsas, the h

Re: [PATCH 1/2] libsas: Don't process sas events in static works

2017-05-20 Thread Dan Williams
On Fri, May 19, 2017 at 11:39 PM, Yijing Wang wrote: > Now libsas hotplug work is static, LLDD driver queue > the hotplug work into shost->work_q. If LLDD driver > burst post lots hotplug events to libsas, the hotplug > events may pending in the workqueue like > > shost->work_q > new work[PORTE_BY

[PATCH 1/2] libsas: Don't process sas events in static works

2017-05-19 Thread Yijing Wang
Now libsas hotplug work is static, LLDD driver queue the hotplug work into shost->work_q. If LLDD driver burst post lots hotplug events to libsas, the hotplug events may pending in the workqueue like shost->work_q new work[PORTE_BYTES_DMAED] --> |[PHYE_LOSS_OF_SIGNAL][PORTE_BYTES_DMAED] -> proces