Re: [PATCH 1/2] lp855x_bl: use generic PWM functions

2012-10-23 Thread Thierry Reding
On Mon, Oct 22, 2012 at 03:30:12PM -0700, Andrew Morton wrote: > On Fri, 19 Oct 2012 08:45:14 + > "Kim, Milo" wrote: > > > > Generally this looks good. Obviously you'll need to update any users of > > > this driver as well. It might make sense to include those changes in > > > this patch to a

Re: [PATCH 1/2] lp855x_bl: use generic PWM functions

2012-10-22 Thread Andrew Morton
On Fri, 19 Oct 2012 08:45:14 + "Kim, Milo" wrote: > > Generally this looks good. Obviously you'll need to update any users of > > this driver as well. It might make sense to include those changes in > > this patch to avoid interim build failures. > > Thanks for your review. > So far no usage

RE: [PATCH 1/2] lp855x_bl: use generic PWM functions

2012-10-19 Thread Kim, Milo
> Generally this looks good. Obviously you'll need to update any users of > this driver as well. It might make sense to include those changes in > this patch to avoid interim build failures. Thanks for your review. So far no usages for this driver in the mainline. I've tested it in my own developm

Re: [PATCH 1/2] lp855x_bl: use generic PWM functions

2012-10-19 Thread Thierry Reding
On Fri, Oct 19, 2012 at 08:11:50AM +, Kim, Milo wrote: > The LP855x family devices support the PWM input for the backlight control. > Period of the PWM is configurable in the platform side. > Platform specific functions are unnecessary anymore because > generic PWM functions are used inside

[PATCH 1/2] lp855x_bl: use generic PWM functions

2012-10-19 Thread Kim, Milo
The LP855x family devices support the PWM input for the backlight control. Period of the PWM is configurable in the platform side. Platform specific functions are unnecessary anymore because generic PWM functions are used inside the driver. (PWM input mode) To set the brightness, new lp855x_