Re: [PATCH 1/2] m68k: Set default dma mask for platform devices

2018-05-30 Thread Geert Uytterhoeven
Hi Finn, On Thu, May 17, 2018 at 12:07 PM, Finn Thain wrote: > This avoids a WARNING splat when loading the macsonic or macmace driver. > Please see commit 205e1b7f51e4 ("dma-mapping: warn when there is no > coherent_dma_mask"). > > This implementation of arch_setup_pdev_archdata() differs from

Re: [PATCH 1/2] m68k: Set default dma mask for platform devices

2018-05-30 Thread Geert Uytterhoeven
Hi Finn, On Thu, May 17, 2018 at 12:07 PM, Finn Thain wrote: > This avoids a WARNING splat when loading the macsonic or macmace driver. > Please see commit 205e1b7f51e4 ("dma-mapping: warn when there is no > coherent_dma_mask"). > > This implementation of arch_setup_pdev_archdata() differs from

Re: [PATCH 1/2] m68k: Set default dma mask for platform devices

2018-05-18 Thread Finn Thain
On Fri, 18 May 2018, Christoph Hellwig wrote: > > This implementation of arch_setup_pdev_archdata() differs from the > > powerpc one, in that this one avoids clobbering a device dma mask > > which has already been initialized. > > I think your implementation should move into the generic

Re: [PATCH 1/2] m68k: Set default dma mask for platform devices

2018-05-18 Thread Finn Thain
On Fri, 18 May 2018, Christoph Hellwig wrote: > > This implementation of arch_setup_pdev_archdata() differs from the > > powerpc one, in that this one avoids clobbering a device dma mask > > which has already been initialized. > > I think your implementation should move into the generic

Re: [PATCH 1/2] m68k: Set default dma mask for platform devices

2018-05-18 Thread Christoph Hellwig
> This implementation of arch_setup_pdev_archdata() differs from the > powerpc one, in that this one avoids clobbering a device dma mask > which has already been initialized. I think your implementation should move into the generic implementation in drivers/base/platform.c instead of being stuck

Re: [PATCH 1/2] m68k: Set default dma mask for platform devices

2018-05-18 Thread Christoph Hellwig
> This implementation of arch_setup_pdev_archdata() differs from the > powerpc one, in that this one avoids clobbering a device dma mask > which has already been initialized. I think your implementation should move into the generic implementation in drivers/base/platform.c instead of being stuck

[PATCH 1/2] m68k: Set default dma mask for platform devices

2018-05-17 Thread Finn Thain
This avoids a WARNING splat when loading the macsonic or macmace driver. Please see commit 205e1b7f51e4 ("dma-mapping: warn when there is no coherent_dma_mask"). This implementation of arch_setup_pdev_archdata() differs from the powerpc one, in that this one avoids clobbering a device dma mask

[PATCH 1/2] m68k: Set default dma mask for platform devices

2018-05-17 Thread Finn Thain
This avoids a WARNING splat when loading the macsonic or macmace driver. Please see commit 205e1b7f51e4 ("dma-mapping: warn when there is no coherent_dma_mask"). This implementation of arch_setup_pdev_archdata() differs from the powerpc one, in that this one avoids clobbering a device dma mask