Re: [PATCH 1/2] media: dvb-usb: Fix memory leak at error in dvb_usb_device_init()

2021-02-01 Thread Takashi Iwai
On Sun, 31 Jan 2021 15:53:20 +0100, Sean Young wrote: > > On Wed, Jan 20, 2021 at 11:20:56AM +0100, Takashi Iwai wrote: > > dvb_usb_device_init() allocates a dvb_usb_device object, but it > > doesn't release it even when returning an error. The callers don't > > seem caring it as well, hence thos

Re: [PATCH 1/2] media: dvb-usb: Fix memory leak at error in dvb_usb_device_init()

2021-01-31 Thread Sean Young
On Wed, Jan 20, 2021 at 11:20:56AM +0100, Takashi Iwai wrote: > dvb_usb_device_init() allocates a dvb_usb_device object, but it > doesn't release it even when returning an error. The callers don't > seem caring it as well, hence those memories are leaked. > > This patch assures releasing the memo

Re: [PATCH 1/2] media: dvb-usb: Fix memory leak at error in dvb_usb_device_init()

2021-01-22 Thread Robert Foss
Hey Takashi, Thanks for the patch. It looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Wed, 20 Jan 2021 at 12:51, Takashi Iwai wrote: > > dvb_usb_device_init() allocates a dvb_usb_device object, but it > doesn't release it even when returning an error. The callers don't

[PATCH 1/2] media: dvb-usb: Fix memory leak at error in dvb_usb_device_init()

2021-01-20 Thread Takashi Iwai
dvb_usb_device_init() allocates a dvb_usb_device object, but it doesn't release it even when returning an error. The callers don't seem caring it as well, hence those memories are leaked. This patch assures releasing the memory at the error path in dvb_usb_device_init(). Also it makes sure that