Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration

2016-09-27 Thread Lee Jones
On Sat, 24 Sep 2016, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/mfd/ab8500-debugfs.c:1587:28: warning: no previous prototype for > 'suspend_test_wake_cause_interrupt_is_mine' [-Wmissing-prototypes] > > In fact, this function need be declared in a header files.

Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration

2016-09-25 Thread Arnd Bergmann
On Sunday 25 September 2016, Baoyou Xie wrote: > On 24 September 2016 at 16:30, Arnd Bergmann wrote: > > > > This can't be right for two reasons: > > > > - the suspend_test_wake_cause_interrupt_is_mine function again > > is only used in the file it is defined in > > > > but, it is declared as w

Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:34:50 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/mfd/ab8500-debugfs.c:1587:28: warning: no previous prototype for > 'suspend_test_wake_cause_interrupt_is_mine' [-Wmissing-prototypes] > > In fact, this function need be de

[PATCH 1/2] mfd: ab8500-debugfs: add function declaration

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/mfd/ab8500-debugfs.c:1587:28: warning: no previous prototype for 'suspend_test_wake_cause_interrupt_is_mine' [-Wmissing-prototypes] In fact, this function need be declared in a header files. So this patch adds function declaration in includ