Re: [PATCH 1/2] mfd: mc13xxx: Do not use platform data with devicetree

2014-05-09 Thread Mark Brown
On Fri, May 09, 2014 at 03:36:29PM +0100, Lee Jones wrote: > > Why not just pull the tag instead? I haven't looked at the patch but > > don't they need to go in together anyway. > Only functionally. They are orthogonally buildable apparently. Working code seems important to bisection too...

Re: [PATCH 1/2] mfd: mc13xxx: Do not use platform data with devicetree

2014-05-09 Thread Lee Jones
> > You need to revert (or remove) the original one and apply: > > > "ASoC: mc13783: Add devicetree support" > > > ... instead. > > Why not just pull the tag instead? I haven't looked at the patch but > don't they need to go in together anyway. Only functionally. They are orthogonally build

Re: [PATCH 1/2] mfd: mc13xxx: Do not use platform data with devicetree

2014-05-09 Thread Mark Brown
On Fri, May 09, 2014 at 03:18:40PM +0100, Lee Jones wrote: > You need to revert (or remove) the original one and apply: > "ASoC: mc13783: Add devicetree support" > ... instead. Why not just pull the tag instead? I haven't looked at the patch but don't they need to go in together anyway. si

Re: [PATCH 1/2] mfd: mc13xxx: Do not use platform data with devicetree

2014-05-09 Thread Lee Jones
On Fri, 09 May 2014, Alexander Shiyan wrote: > Fri, 9 May 2014 12:30:30 +0100 от Lee Jones : > > > This patch removes platform data usage for codec and touchscreen > > > when driver is used with devicetree. > > > This fixes possible "null pointer dereference" error if DTS uses > > > "fsl,mc13xxx-u

Re: [PATCH 1/2] mfd: mc13xxx: Do not use platform data with devicetree

2014-05-09 Thread Alexander Shiyan
Fri, 9 May 2014 12:30:30 +0100 от Lee Jones : > > This patch removes platform data usage for codec and touchscreen > > when driver is used with devicetree. > > This fixes possible "null pointer dereference" error if DTS uses > > "fsl,mc13xxx-uses-codec" or "fsl,mc13xxx-uses-touch" options. > > > >

Re: [PATCH 1/2] mfd: mc13xxx: Do not use platform data with devicetree

2014-05-09 Thread Lee Jones
> This patch removes platform data usage for codec and touchscreen > when driver is used with devicetree. > This fixes possible "null pointer dereference" error if DTS uses > "fsl,mc13xxx-uses-codec" or "fsl,mc13xxx-uses-touch" options. > > Signed-off-by: Alexander Shiyan > --- > drivers/mfd/mc1

[PATCH 1/2] mfd: mc13xxx: Do not use platform data with devicetree

2014-04-30 Thread Alexander Shiyan
This patch removes platform data usage for codec and touchscreen when driver is used with devicetree. This fixes possible "null pointer dereference" error if DTS uses "fsl,mc13xxx-uses-codec" or "fsl,mc13xxx-uses-touch" options. Signed-off-by: Alexander Shiyan --- drivers/mfd/mc13xxx-core.c | 18