Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-13 Thread Michal Hocko
On Fri 13-10-17 22:42:46, Michael Ellerman wrote: > Vlastimil Babka writes: > > On 10/11/2017 08:51 AM, Michal Hocko wrote: > >> On Wed 11-10-17 13:37:50, Michael Ellerman wrote: > >>> Michal Hocko writes: > On Tue 10-10-17 23:05:08, Michael Ellerman wrote: > > Michal Hocko writes: > >>

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-13 Thread Michael Ellerman
Vlastimil Babka writes: > On 10/11/2017 08:51 AM, Michal Hocko wrote: >> On Wed 11-10-17 13:37:50, Michael Ellerman wrote: >>> Michal Hocko writes: On Tue 10-10-17 23:05:08, Michael Ellerman wrote: > Michal Hocko writes: >> From: Michal Hocko >> >> Memory offlining can fail

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-11 Thread Michal Hocko
On Wed 11-10-17 19:35:04, Anshuman Khandual wrote: [...] > > $ grep __init_begin /proc/kallsyms > > c0d7 T __init_begin > > $ ./page-types -r -a 0x0,0xd7 > >flagspage-count MB symbolic-flags > > long-symbolic-flags > > 0x00

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-11 Thread Anshuman Khandual
On 10/11/2017 10:49 AM, Michael Ellerman wrote: > Michael Ellerman writes: >> Michal Hocko writes: >>> On Tue 10-10-17 23:05:08, Michael Ellerman wrote: Michal Hocko writes: > From: Michal Hocko > Memory offlining can fail just too eagerly under a heavy memory pressure. > >

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-11 Thread Michal Hocko
On Wed 11-10-17 13:17:13, Vlastimil Babka wrote: > On 10/11/2017 10:13 AM, Michal Hocko wrote: > > On Wed 11-10-17 10:04:39, Vlastimil Babka wrote: > >> On 10/11/2017 08:51 AM, Michal Hocko wrote: > > [...] > >>> This is really strange! As you write in other email the page is > >>> reserved. That m

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-11 Thread Vlastimil Babka
On 10/11/2017 10:13 AM, Michal Hocko wrote: > On Wed 11-10-17 10:04:39, Vlastimil Babka wrote: >> On 10/11/2017 08:51 AM, Michal Hocko wrote: > [...] >>> This is really strange! As you write in other email the page is >>> reserved. That means that some of the earlier checks >>> if (zone_idx(zo

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-11 Thread Michal Hocko
On Wed 11-10-17 10:04:39, Vlastimil Babka wrote: > On 10/11/2017 08:51 AM, Michal Hocko wrote: [...] > > This is really strange! As you write in other email the page is > > reserved. That means that some of the earlier checks > > if (zone_idx(zone) == ZONE_MOVABLE) > > return false

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-11 Thread Vlastimil Babka
On 10/11/2017 08:51 AM, Michal Hocko wrote: > On Wed 11-10-17 13:37:50, Michael Ellerman wrote: >> Michal Hocko writes: >> >>> On Tue 10-10-17 23:05:08, Michael Ellerman wrote: Michal Hocko writes: > From: Michal Hocko > > Memory offlining can fail just too eagerly under a

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-10 Thread Michal Hocko
On Wed 11-10-17 13:37:50, Michael Ellerman wrote: > Michal Hocko writes: > > > On Tue 10-10-17 23:05:08, Michael Ellerman wrote: > >> Michal Hocko writes: > >> > >> > From: Michal Hocko > >> > > >> > Memory offlining can fail just too eagerly under a heavy memory pressure. > >> > > >> > [ 5410

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-10 Thread Michael Ellerman
Michael Ellerman writes: > Michal Hocko writes: >> On Tue 10-10-17 23:05:08, Michael Ellerman wrote: >>> Michal Hocko writes: >>> > From: Michal Hocko >>> > Memory offlining can fail just too eagerly under a heavy memory pressure. >>> > >>> > [ 5410.336792] page:ea22a646bd00 count:255 mapco

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-10 Thread Michael Ellerman
Michal Hocko writes: > On Tue 10-10-17 23:05:08, Michael Ellerman wrote: >> Michal Hocko writes: >> >> > From: Michal Hocko >> > >> > Memory offlining can fail just too eagerly under a heavy memory pressure. >> > >> > [ 5410.336792] page:ea22a646bd00 count:255 mapcount:252 >> > mapping:ff

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-10 Thread Michal Hocko
On Tue 10-10-17 23:05:08, Michael Ellerman wrote: > Michal Hocko writes: > > > From: Michal Hocko > > > > Memory offlining can fail just too eagerly under a heavy memory pressure. > > > > [ 5410.336792] page:ea22a646bd00 count:255 mapcount:252 > > mapping:88ff926c9f38 index:0x3 > > [ 54

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-10-10 Thread Michael Ellerman
Michal Hocko writes: > From: Michal Hocko > > Memory offlining can fail just too eagerly under a heavy memory pressure. > > [ 5410.336792] page:ea22a646bd00 count:255 mapcount:252 > mapping:88ff926c9f38 index:0x3 > [ 5410.336809] flags: 0x9855fe40010048(uptodate|active|mappedtodisk) > [

[PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-18 Thread Michal Hocko
From: Michal Hocko Memory offlining can fail just too eagerly under a heavy memory pressure. [ 5410.336792] page:ea22a646bd00 count:255 mapcount:252 mapping:88ff926c9f38 index:0x3 [ 5410.336809] flags: 0x9855fe40010048(uptodate|active|mappedtodisk) [ 5410.336811] page dumped because: is

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-13 Thread Michal Hocko
you think about the following wording: > > > > Ups, wrong patch > > > > > > From 8639496a834b4a7c24972ec23b17e50f0d6a304c Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Mon, 14 Aug 2017 10:46:12 +0200 > > Subject: [PATCH 1/2] mm, memory_

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-13 Thread Vlastimil Babka
t; From 8639496a834b4a7c24972ec23b17e50f0d6a304c Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Mon, 14 Aug 2017 10:46:12 +0200 > Subject: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early > > Memory offlining can fail just too eagerly under a heavy memo

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-13 Thread Michal Hocko
think that the changelog should be more clear about this? > > > > It certainly wouldn't hurt :) > > So what do you think about the following wording: Ups, wrong patch >From 8639496a834b4a7c24972ec23b17e50f0d6a304c Mon Sep 17 00:00:00 2001 From: Michal Hocko Date:

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-13 Thread Michal Hocko
On Wed 13-09-17 13:41:20, Vlastimil Babka wrote: > On 09/11/2017 10:17 AM, Michal Hocko wrote: [...] > > Yes, we should be able to distinguish the two and hopefully we can teach > > the migration code to distinguish between EBUSY (likely permanent) and > > EGAIN (temporal) failure. This sound like

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-13 Thread Vlastimil Babka
On 09/11/2017 10:17 AM, Michal Hocko wrote: > On Fri 08-09-17 19:26:06, Vlastimil Babka wrote: >> On 09/04/2017 10:21 AM, Michal Hocko wrote: >>> From: Michal Hocko >>> >>> Fix this by removing the max retry count and only rely on the timeout >>> resp. interruption by a signal from the userspace.

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-11 Thread Michal Hocko
On Fri 08-09-17 19:26:06, Vlastimil Babka wrote: > On 09/04/2017 10:21 AM, Michal Hocko wrote: > > From: Michal Hocko > > > > Memory offlining can fail just too eagerly under a heavy memory pressure. > > > > [ 5410.336792] page:ea22a646bd00 count:255 mapcount:252 > > mapping:88ff926c9f3

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-08 Thread Vlastimil Babka
On 09/04/2017 10:21 AM, Michal Hocko wrote: > From: Michal Hocko > > Memory offlining can fail just too eagerly under a heavy memory pressure. > > [ 5410.336792] page:ea22a646bd00 count:255 mapcount:252 > mapping:88ff926c9f38 index:0x3 > [ 5410.336809] flags: 0x9855fe40010048(uptodate|a

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-05 Thread Michal Hocko
On Tue 05-09-17 11:59:36, Anshuman Khandual wrote: [...] > > @@ -1634,43 +1634,25 @@ static int __ref __offline_pages(unsigned long > > start_pfn, > > > > pfn = start_pfn; > > expire = jiffies + timeout; > > - drain = 0; > > - retry_max = 5; > > repeat: > > /* start memory hot r

Re: [PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-04 Thread Anshuman Khandual
On 09/04/2017 01:51 PM, Michal Hocko wrote: > From: Michal Hocko > > Memory offlining can fail just too eagerly under a heavy memory pressure. > > [ 5410.336792] page:ea22a646bd00 count:255 mapcount:252 > mapping:88ff926c9f38 index:0x3 > [ 5410.336809] flags: 0x9855fe40010048(uptodate|a

[PATCH 1/2] mm, memory_hotplug: do not fail offlining too early

2017-09-04 Thread Michal Hocko
From: Michal Hocko Memory offlining can fail just too eagerly under a heavy memory pressure. [ 5410.336792] page:ea22a646bd00 count:255 mapcount:252 mapping:88ff926c9f38 index:0x3 [ 5410.336809] flags: 0x9855fe40010048(uptodate|active|mappedtodisk) [ 5410.336811] page dumped because: is