Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-30 Thread Michal Nazarewicz
On Tue, Jul 21 2015, Vlastimil Babka wrote: > The __test_page_isolated_in_pageblock() is used to verify whether all pages > in pageblock were either successfully isolated, or are hwpoisoned. Two of the > possible state of pages, that are tested, are however bogus and misleading. > > Both tests

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-30 Thread Michal Nazarewicz
On Tue, Jul 21 2015, Vlastimil Babka wrote: The __test_page_isolated_in_pageblock() is used to verify whether all pages in pageblock were either successfully isolated, or are hwpoisoned. Two of the possible state of pages, that are tested, are however bogus and misleading. Both tests rely on

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-29 Thread Mel Gorman
On Tue, Jul 21, 2015 at 02:53:37PM +0200, Vlastimil Babka wrote: > The __test_page_isolated_in_pageblock() is used to verify whether all pages > in pageblock were either successfully isolated, or are hwpoisoned. Two of the > possible state of pages, that are tested, are however bogus and

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-29 Thread Mel Gorman
On Tue, Jul 21, 2015 at 02:53:37PM +0200, Vlastimil Babka wrote: The __test_page_isolated_in_pageblock() is used to verify whether all pages in pageblock were either successfully isolated, or are hwpoisoned. Two of the possible state of pages, that are tested, are however bogus and misleading.

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-22 Thread Naoya Horiguchi
On Tue, Jul 21, 2015 at 02:53:37PM +0200, Vlastimil Babka wrote: > The __test_page_isolated_in_pageblock() is used to verify whether all pages > in pageblock were either successfully isolated, or are hwpoisoned. Two of the > possible state of pages, that are tested, are however bogus and

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-22 Thread Joonsoo Kim
On Tue, Jul 21, 2015 at 02:53:37PM +0200, Vlastimil Babka wrote: > The __test_page_isolated_in_pageblock() is used to verify whether all pages > in pageblock were either successfully isolated, or are hwpoisoned. Two of the > possible state of pages, that are tested, are however bogus and

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-22 Thread David Rientjes
On Wed, 22 Jul 2015, Vlastimil Babka wrote: > From: Vlastimil Babka > Date: Wed, 22 Jul 2015 14:16:52 +0200 > Subject: [PATCH 2/3] fixup! mm, page_isolation: remove bogus tests for > isolated pages > > --- > mm/page_alloc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-22 Thread Vlastimil Babka
On 07/22/2015 12:43 AM, David Rientjes wrote: > On Tue, 21 Jul 2015, Vlastimil Babka wrote: > > > You may want to consider stating your assumptions explicitly in the code, > perhaps with VM_BUG_ON(), such as in free_pcppages_bulk() to ensure things > like get_freepage_migratetype(page) !=

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-22 Thread David Rientjes
On Wed, 22 Jul 2015, Vlastimil Babka wrote: From: Vlastimil Babka vba...@suse.cz Date: Wed, 22 Jul 2015 14:16:52 +0200 Subject: [PATCH 2/3] fixup! mm, page_isolation: remove bogus tests for isolated pages --- mm/page_alloc.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-22 Thread Joonsoo Kim
On Tue, Jul 21, 2015 at 02:53:37PM +0200, Vlastimil Babka wrote: The __test_page_isolated_in_pageblock() is used to verify whether all pages in pageblock were either successfully isolated, or are hwpoisoned. Two of the possible state of pages, that are tested, are however bogus and misleading.

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-22 Thread Naoya Horiguchi
On Tue, Jul 21, 2015 at 02:53:37PM +0200, Vlastimil Babka wrote: The __test_page_isolated_in_pageblock() is used to verify whether all pages in pageblock were either successfully isolated, or are hwpoisoned. Two of the possible state of pages, that are tested, are however bogus and misleading.

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-22 Thread Vlastimil Babka
On 07/22/2015 12:43 AM, David Rientjes wrote: On Tue, 21 Jul 2015, Vlastimil Babka wrote: You may want to consider stating your assumptions explicitly in the code, perhaps with VM_BUG_ON(), such as in free_pcppages_bulk() to ensure things like get_freepage_migratetype(page) !=

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-21 Thread David Rientjes
On Tue, 21 Jul 2015, Vlastimil Babka wrote: > The __test_page_isolated_in_pageblock() is used to verify whether all pages > in pageblock were either successfully isolated, or are hwpoisoned. Two of the > possible state of pages, that are tested, are however bogus and misleading. > > Both tests

[PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-21 Thread Vlastimil Babka
The __test_page_isolated_in_pageblock() is used to verify whether all pages in pageblock were either successfully isolated, or are hwpoisoned. Two of the possible state of pages, that are tested, are however bogus and misleading. Both tests rely on get_freepage_migratetype(page), which however

Re: [PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-21 Thread David Rientjes
On Tue, 21 Jul 2015, Vlastimil Babka wrote: The __test_page_isolated_in_pageblock() is used to verify whether all pages in pageblock were either successfully isolated, or are hwpoisoned. Two of the possible state of pages, that are tested, are however bogus and misleading. Both tests rely

[PATCH 1/2] mm, page_isolation: remove bogus tests for isolated pages

2015-07-21 Thread Vlastimil Babka
The __test_page_isolated_in_pageblock() is used to verify whether all pages in pageblock were either successfully isolated, or are hwpoisoned. Two of the possible state of pages, that are tested, are however bogus and misleading. Both tests rely on get_freepage_migratetype(page), which however