Re: [PATCH 1/2] mm/zsmalloc: adjust order of functions

2014-12-15 Thread Minchan Kim
On Tue, Dec 16, 2014 at 12:08:02PM +0800, Ganesh Mahendran wrote: > Hello Minchan, > > > 2014-12-16 8:40 GMT+08:00 Minchan Kim : > > Hello Ganesh, > > > > On Sat, Dec 13, 2014 at 09:43:23PM +0800, Ganesh Mahendran wrote: > >> Currently functions in zsmalloc.c does not arranged in a readable > >>

Re: [PATCH 1/2] mm/zsmalloc: adjust order of functions

2014-12-15 Thread Ganesh Mahendran
Hello Minchan, 2014-12-16 8:40 GMT+08:00 Minchan Kim : > Hello Ganesh, > > On Sat, Dec 13, 2014 at 09:43:23PM +0800, Ganesh Mahendran wrote: >> Currently functions in zsmalloc.c does not arranged in a readable >> and reasonable sequence. With the more and more functions added, >> we may meet

Re: [PATCH 1/2] mm/zsmalloc: adjust order of functions

2014-12-15 Thread Minchan Kim
Hello Ganesh, On Sat, Dec 13, 2014 at 09:43:23PM +0800, Ganesh Mahendran wrote: > Currently functions in zsmalloc.c does not arranged in a readable > and reasonable sequence. With the more and more functions added, > we may meet below inconvenience. For example: > > Current functions: > void

Re: [PATCH 1/2] mm/zsmalloc: adjust order of functions

2014-12-15 Thread Minchan Kim
Hello Ganesh, On Sat, Dec 13, 2014 at 09:43:23PM +0800, Ganesh Mahendran wrote: Currently functions in zsmalloc.c does not arranged in a readable and reasonable sequence. With the more and more functions added, we may meet below inconvenience. For example: Current functions: void

Re: [PATCH 1/2] mm/zsmalloc: adjust order of functions

2014-12-15 Thread Ganesh Mahendran
Hello Minchan, 2014-12-16 8:40 GMT+08:00 Minchan Kim minc...@kernel.org: Hello Ganesh, On Sat, Dec 13, 2014 at 09:43:23PM +0800, Ganesh Mahendran wrote: Currently functions in zsmalloc.c does not arranged in a readable and reasonable sequence. With the more and more functions added, we may

Re: [PATCH 1/2] mm/zsmalloc: adjust order of functions

2014-12-15 Thread Minchan Kim
On Tue, Dec 16, 2014 at 12:08:02PM +0800, Ganesh Mahendran wrote: Hello Minchan, 2014-12-16 8:40 GMT+08:00 Minchan Kim minc...@kernel.org: Hello Ganesh, On Sat, Dec 13, 2014 at 09:43:23PM +0800, Ganesh Mahendran wrote: Currently functions in zsmalloc.c does not arranged in a readable

[PATCH 1/2] mm/zsmalloc: adjust order of functions

2014-12-13 Thread Ganesh Mahendran
Currently functions in zsmalloc.c does not arranged in a readable and reasonable sequence. With the more and more functions added, we may meet below inconvenience. For example: Current functions: void zs_init() { } static void get_maxobj_per_zspage() { } Then I want to

[PATCH 1/2] mm/zsmalloc: adjust order of functions

2014-12-13 Thread Ganesh Mahendran
Currently functions in zsmalloc.c does not arranged in a readable and reasonable sequence. With the more and more functions added, we may meet below inconvenience. For example: Current functions: void zs_init() { } static void get_maxobj_per_zspage() { } Then I want to