Re: [PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg

2020-09-01 Thread Yang Shi
This report is kind of late, hope everyone still remembers the context. I just happened to see a similar problem on our v4.19 kernel, please see the below output from memory.stat: total_cache 7361626112 total_rss 8268165120 total_rss_huge 0 total_shmem 0 total_mapped_file 4154929152 total_dirty 3

Re: [PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg

2019-08-14 Thread Michal Hocko
On Mon 12-08-19 15:29:10, Roman Gushchin wrote: > Percpu caching of local vmstats with the conditional propagation > by the cgroup tree leads to an accumulation of errors on non-leaf > levels. > > Let's imagine two nested memory cgroups A and A/B. Say, a process > belonging to A/B allocates 100 pa

Re: [PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg

2019-08-13 Thread Roman Gushchin
On Tue, Aug 13, 2019 at 02:27:52PM -0700, Andrew Morton wrote: > On Mon, 12 Aug 2019 15:29:10 -0700 Roman Gushchin wrote: > > > Percpu caching of local vmstats with the conditional propagation > > by the cgroup tree leads to an accumulation of errors on non-leaf > > levels. > > > > Let's imagine

Re: [PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg

2019-08-13 Thread Andrew Morton
On Mon, 12 Aug 2019 15:29:10 -0700 Roman Gushchin wrote: > Percpu caching of local vmstats with the conditional propagation > by the cgroup tree leads to an accumulation of errors on non-leaf > levels. > > Let's imagine two nested memory cgroups A and A/B. Say, a process > belonging to A/B alloc

[PATCH 1/2] mm: memcontrol: flush percpu vmstats before releasing memcg

2019-08-12 Thread Roman Gushchin
Percpu caching of local vmstats with the conditional propagation by the cgroup tree leads to an accumulation of errors on non-leaf levels. Let's imagine two nested memory cgroups A and A/B. Say, a process belonging to A/B allocates 100 pagecache pages on the CPU 0. The percpu cache will spill 3 ti