Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

> On Aug 5, 2016, at 10:00 PM, Steven Rostedt wrote: > >> > > You probably want to clear the trace here, or set function_graph here > first. Because the function graph starts writing to the buffer > immediately. > I did that, just didn’t include it here :) >> > > When

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

> On Aug 5, 2016, at 10:00 PM, Steven Rostedt wrote: > >> > > You probably want to clear the trace here, or set function_graph here > first. Because the function graph starts writing to the buffer > immediately. > I did that, just didn’t include it here :) >> > > When threshold is set,

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Fri, 5 Aug 2016 21:33:25 +0530 Janani Ravichandran wrote: > > Hmm, looking at the code, it appears setting tracing_thresh should > > work. Could you show me exactly what you did? > > > > Sure. I wanted to observe how long it took to allocate pages and also how

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Fri, 5 Aug 2016 21:33:25 +0530 Janani Ravichandran wrote: > > Hmm, looking at the code, it appears setting tracing_thresh should > > work. Could you show me exactly what you did? > > > > Sure. I wanted to observe how long it took to allocate pages and also how > long functions in the

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

> On Aug 4, 2016, at 8:49 PM, Steven Rostedt wrote: > > On Fri, 29 Jul 2016 01:41:20 +0530 > Janani Ravichandran wrote: > > Sorry for the late reply, I've been swamped with other things since > coming back from my vacation. > No problem! > >

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

> On Aug 4, 2016, at 8:49 PM, Steven Rostedt wrote: > > On Fri, 29 Jul 2016 01:41:20 +0530 > Janani Ravichandran wrote: > > Sorry for the late reply, I've been swamped with other things since > coming back from my vacation. > No problem! > > Hmm, looking at the code, it appears setting

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Fri, 29 Jul 2016 01:41:20 +0530 Janani Ravichandran wrote: Sorry for the late reply, I've been swamped with other things since coming back from my vacation. > I looked at function graph trace, as you’d suggested. I saw that I could set > a threshold > there using

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Fri, 29 Jul 2016 01:41:20 +0530 Janani Ravichandran wrote: Sorry for the late reply, I've been swamped with other things since coming back from my vacation. > I looked at function graph trace, as you’d suggested. I saw that I could set > a threshold > there using tracing_thresh. But the

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

> On Jul 27, 2016, at 8:53 PM, Steven Rostedt wrote: > > I'm thinking you only need one tracepoint, and use function_graph > tracer for the length of the function call. > > # cd /sys/kernel/debug/tracing > # echo __alloc_pages_nodemask > set_ftrace_filter > # echo

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

> On Jul 27, 2016, at 8:53 PM, Steven Rostedt wrote: > > I'm thinking you only need one tracepoint, and use function_graph > tracer for the length of the function call. > > # cd /sys/kernel/debug/tracing > # echo __alloc_pages_nodemask > set_ftrace_filter > # echo function_graph >

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 2016-07-27 at 20:44 +0200, Michal Hocko wrote: > On Wed 27-07-16 14:16:22, Rik van Riel wrote: > > > > On Wed, 2016-07-27 at 18:33 +0200, Michal Hocko wrote: > > > > > > On Wed 27-07-16 10:47:59, Janani Ravichandran wrote: > > > > > > > > > > > > Add tracepoints to the slowpath code to

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 2016-07-27 at 20:44 +0200, Michal Hocko wrote: > On Wed 27-07-16 14:16:22, Rik van Riel wrote: > > > > On Wed, 2016-07-27 at 18:33 +0200, Michal Hocko wrote: > > > > > > On Wed 27-07-16 10:47:59, Janani Ravichandran wrote: > > > > > > > > > > > > Add tracepoints to the slowpath code to

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed 27-07-16 14:16:22, Rik van Riel wrote: > On Wed, 2016-07-27 at 18:33 +0200, Michal Hocko wrote: > > On Wed 27-07-16 10:47:59, Janani Ravichandran wrote: > > > > > > Add tracepoints to the slowpath code to gather some information. > > > The tracepoints can also be used to find out how much

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed 27-07-16 14:16:22, Rik van Riel wrote: > On Wed, 2016-07-27 at 18:33 +0200, Michal Hocko wrote: > > On Wed 27-07-16 10:47:59, Janani Ravichandran wrote: > > > > > > Add tracepoints to the slowpath code to gather some information. > > > The tracepoints can also be used to find out how much

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 27 Jul 2016 14:16:22 -0400 Rik van Riel wrote: > As for the function tracer, I wish I had known > about that! The kernel (and just the tracing infrastructure) is too big to know everything that is there. > > That looks like it should provide the info that > Janani

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 27 Jul 2016 14:16:22 -0400 Rik van Riel wrote: > As for the function tracer, I wish I had known > about that! The kernel (and just the tracing infrastructure) is too big to know everything that is there. > > That looks like it should provide the info that > Janani needs to write her

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 2016-07-27 at 18:33 +0200, Michal Hocko wrote: > On Wed 27-07-16 10:47:59, Janani Ravichandran wrote: > > > > Add tracepoints to the slowpath code to gather some information. > > The tracepoints can also be used to find out how much time was > > spent in > > the slowpath. > I do not think

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 2016-07-27 at 18:33 +0200, Michal Hocko wrote: > On Wed 27-07-16 10:47:59, Janani Ravichandran wrote: > > > > Add tracepoints to the slowpath code to gather some information. > > The tracepoints can also be used to find out how much time was > > spent in > > the slowpath. > I do not think

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 27 Jul 2016 10:20:28 -0700 Dave Hansen wrote: > On 07/27/2016 08:23 AM, Steven Rostedt wrote: > >> > + > >> > +trace_mm_slowpath_end(page); > >> > + > > I'm thinking you only need one tracepoint, and use function_graph > > tracer for the length of the

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 27 Jul 2016 10:20:28 -0700 Dave Hansen wrote: > On 07/27/2016 08:23 AM, Steven Rostedt wrote: > >> > + > >> > +trace_mm_slowpath_end(page); > >> > + > > I'm thinking you only need one tracepoint, and use function_graph > > tracer for the length of the function call. > > > > #

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On 07/27/2016 08:23 AM, Steven Rostedt wrote: >> > + >> > + trace_mm_slowpath_end(page); >> > + > I'm thinking you only need one tracepoint, and use function_graph > tracer for the length of the function call. > > # cd /sys/kernel/debug/tracing > # echo __alloc_pages_nodemask >

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On 07/27/2016 08:23 AM, Steven Rostedt wrote: >> > + >> > + trace_mm_slowpath_end(page); >> > + > I'm thinking you only need one tracepoint, and use function_graph > tracer for the length of the function call. > > # cd /sys/kernel/debug/tracing > # echo __alloc_pages_nodemask >

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed 27-07-16 10:47:59, Janani Ravichandran wrote: > Add tracepoints to the slowpath code to gather some information. > The tracepoints can also be used to find out how much time was spent in > the slowpath. I do not think this is a right thing to measure. __alloc_pages_slowpath is more a code

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed 27-07-16 10:47:59, Janani Ravichandran wrote: > Add tracepoints to the slowpath code to gather some information. > The tracepoints can also be used to find out how much time was spent in > the slowpath. I do not think this is a right thing to measure. __alloc_pages_slowpath is more a code

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 27 Jul 2016 10:47:59 -0400 Janani Ravichandran wrote: > Add tracepoints to the slowpath code to gather some information. > The tracepoints can also be used to find out how much time was spent in > the slowpath. > > Signed-off-by: Janani Ravichandran

Re: [PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

On Wed, 27 Jul 2016 10:47:59 -0400 Janani Ravichandran wrote: > Add tracepoints to the slowpath code to gather some information. > The tracepoints can also be used to find out how much time was spent in > the slowpath. > > Signed-off-by: Janani Ravichandran > --- > include/trace/events/kmem.h

[PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

Add tracepoints to the slowpath code to gather some information. The tracepoints can also be used to find out how much time was spent in the slowpath. Signed-off-by: Janani Ravichandran --- include/trace/events/kmem.h | 40

[PATCH 1/2] mm: page_alloc.c: Add tracepoints for slowpath

Add tracepoints to the slowpath code to gather some information. The tracepoints can also be used to find out how much time was spent in the slowpath. Signed-off-by: Janani Ravichandran --- include/trace/events/kmem.h | 40 mm/page_alloc.c |