Re: [PATCH 1/2] mm:swap: clean up swap readahead

2017-10-31 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > On Wed, Nov 01, 2017 at 01:41:00PM +0800, Huang, Ying wrote: >> Hi, Minchan, >> >> Minchan Kim writes: >> >> > When I see recent change of swap readahead, I am very unhappy >> > about current code structure which diverges two swap readahead >> > algorithm in

Re: [PATCH 1/2] mm:swap: clean up swap readahead

2017-10-31 Thread Minchan Kim
Hi Huang, On Wed, Nov 01, 2017 at 01:41:00PM +0800, Huang, Ying wrote: > Hi, Minchan, > > Minchan Kim writes: > > > When I see recent change of swap readahead, I am very unhappy > > about current code structure which diverges two swap readahead > > algorithm in do_swap_page. This patch is to cl

Re: [PATCH 1/2] mm:swap: clean up swap readahead

2017-10-31 Thread Huang, Ying
Hi, Minchan, Minchan Kim writes: > When I see recent change of swap readahead, I am very unhappy > about current code structure which diverges two swap readahead > algorithm in do_swap_page. This patch is to clean it up. > > Main motivation is that fault handler doesn't need to be aware of > rea

[PATCH 1/2] mm:swap: clean up swap readahead

2017-10-31 Thread Minchan Kim
When I see recent change of swap readahead, I am very unhappy about current code structure which diverges two swap readahead algorithm in do_swap_page. This patch is to clean it up. Main motivation is that fault handler doesn't need to be aware of readahead algorithms but just should call swapin_r