Re: [PATCH 1/2] mmc: v4.14: Fix null pointer dereference in mmc_init_request

2019-05-13 Thread Raul Rangel
> > Errm. I think we need to fix that problem instead of working around it. > So mmc_request_fn already has a null check, it was just missing on > mmc_init_request. > So I got 189650 random connect/disconnect iterations over the weekend with these patches. I think they are fine. I'm going to send

Re: [PATCH 1/2] mmc: v4.14: Fix null pointer dereference in mmc_init_request

2019-05-09 Thread Raul Rangel
On Wed, May 08, 2019 at 11:04:56PM -0700, Christoph Hellwig wrote: > On Wed, May 08, 2019 at 12:58:32PM -0600, Raul E Rangel wrote: > > It is possible for queuedata to be cleared in mmc_cleanup_queue before > > the request has been started. > > Errm. I think we need to fix that problem instead of

Re: [PATCH 1/2] mmc: v4.14: Fix null pointer dereference in mmc_init_request

2019-05-08 Thread Christoph Hellwig
On Wed, May 08, 2019 at 12:58:32PM -0600, Raul E Rangel wrote: > It is possible for queuedata to be cleared in mmc_cleanup_queue before > the request has been started. Errm. I think we need to fix that problem instead of working around it.

[PATCH 1/2] mmc: v4.14: Fix null pointer dereference in mmc_init_request

2019-05-08 Thread Raul E Rangel
It is possible for queuedata to be cleared in mmc_cleanup_queue before the request has been started. This will result in dereferencing a null pointer. Signed-off-by: Raul E Rangel --- I think we should cherry-pick 41e3efd07d5a02c80f503e29d755aa1bbb4245de https://lore.kernel.org/patchwork/patch/85