Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-09-04 Thread Pavel Machek
Hi! > index 1413828..029c87d 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2002,7 +2002,17 @@ int spi_nor_scan(struct spi_nor *nor, const char *name, > if (JEDEC_MFR(info) == SNOR_MFR_SPANSION || > info->flags &

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-09-04 Thread Pavel Machek
Hi! > index 1413828..029c87d 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2002,7 +2002,17 @@ int spi_nor_scan(struct spi_nor *nor, const char *name, > if (JEDEC_MFR(info) == SNOR_MFR_SPANSION || > info->flags &

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-29 Thread Marcin Wojtas
Hi Marek, 2017-08-29 1:24 GMT+02:00 Marek Vasut : > On 08/28/2017 11:14 PM, Marcin Wojtas wrote: >> Hitherto code set 4B addressing mode for all SPI flashes whose >> size exceeds 16MB. However, changing the default 3B access >> in some cases may be harmful - it may happen

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-29 Thread Marcin Wojtas
Hi Marek, 2017-08-29 1:24 GMT+02:00 Marek Vasut : > On 08/28/2017 11:14 PM, Marcin Wojtas wrote: >> Hitherto code set 4B addressing mode for all SPI flashes whose >> size exceeds 16MB. However, changing the default 3B access >> in some cases may be harmful - it may happen that the Boot ROM >> is

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-28 Thread Marek Vasut
On 08/28/2017 11:14 PM, Marcin Wojtas wrote: > Hitherto code set 4B addressing mode for all SPI flashes whose > size exceeds 16MB. However, changing the default 3B access > in some cases may be harmful - it may happen that the Boot ROM > is not capable of handling non-default state of the SPI NOR

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-28 Thread Marek Vasut
On 08/28/2017 11:14 PM, Marcin Wojtas wrote: > Hitherto code set 4B addressing mode for all SPI flashes whose > size exceeds 16MB. However, changing the default 3B access > in some cases may be harmful - it may happen that the Boot ROM > is not capable of handling non-default state of the SPI NOR

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-28 Thread Marcin Wojtas
Hi Geert, >> +- spi-3byte-addressing - Empty property indicating device access to be done >> + only in 3byte addressing mode. > > spi-force-3byte-addressing? I can change it, no problem. I thought of this, but was affraid if the property wouldn't be too long. > >> Some SPI

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-28 Thread Marcin Wojtas
Hi Geert, >> +- spi-3byte-addressing - Empty property indicating device access to be done >> + only in 3byte addressing mode. > > spi-force-3byte-addressing? I can change it, no problem. I thought of this, but was affraid if the property wouldn't be too long. > >> Some SPI

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-28 Thread Geert Uytterhoeven
On Mon, Aug 28, 2017 at 11:14 PM, Marcin Wojtas wrote: > Hitherto code set 4B addressing mode for all SPI flashes whose > size exceeds 16MB. However, changing the default 3B access > in some cases may be harmful - it may happen that the Boot ROM > is not capable of handling

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-28 Thread Geert Uytterhoeven
On Mon, Aug 28, 2017 at 11:14 PM, Marcin Wojtas wrote: > Hitherto code set 4B addressing mode for all SPI flashes whose > size exceeds 16MB. However, changing the default 3B access > in some cases may be harmful - it may happen that the Boot ROM > is not capable of handling non-default state of

[PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-28 Thread Marcin Wojtas
Hitherto code set 4B addressing mode for all SPI flashes whose size exceeds 16MB. However, changing the default 3B access in some cases may be harmful - it may happen that the Boot ROM is not capable of handling non-default state of the SPI NOR (e.g. after soft reset). Some flash devices allow to

[PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

2017-08-28 Thread Marcin Wojtas
Hitherto code set 4B addressing mode for all SPI flashes whose size exceeds 16MB. However, changing the default 3B access in some cases may be harmful - it may happen that the Boot ROM is not capable of handling non-default state of the SPI NOR (e.g. after soft reset). Some flash devices allow to