Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Andrew Lunn
> i'll think about the frame-generator; Here were the two main problems i can remember with my first version: How do you discover what is can actually do? You probably need to collect up all the open PHY datasheets and get an idea what the different vendors provide, what is common, what could be

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 5:13 PM Andrew Lunn wrote: > > > The frame-generator is an interesting feature of the PHY, that's not > > useful for the current phylib; the PHY can send packages [like a > > signal generator], and then these can be looped back, or sent over the > > wire. > removed my

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Andrew Lunn
> The frame-generator is an interesting feature of the PHY, that's not > useful for the current phylib; the PHY can send packages [like a > signal generator], and then these can be looped back, or sent over the > wire. Many PHYs that that. I posted some patches to the list a few years ago adding

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 4:58 PM Andrew Lunn wrote: > > On Wed, Oct 21, 2020 at 04:51:39PM +0300, Alexandru Ardelean wrote: > > The LINKING_EN bit is always cleared during reset. Initially it was set > > during the downshift setup, because it's in the same register as the > > downshift retry count

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Andrew Lunn
On Wed, Oct 21, 2020 at 04:51:39PM +0300, Alexandru Ardelean wrote: > The LINKING_EN bit is always cleared during reset. Initially it was set > during the downshift setup, because it's in the same register as the > downshift retry count (PHY_CTRL1). Hi Alexandru For those of us how have not read

[PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
The LINKING_EN bit is always cleared during reset. Initially it was set during the downshift setup, because it's in the same register as the downshift retry count (PHY_CTRL1). This change moves the handling of LINKING_EN from the downshift handler to the autonegotiation handler. Also, during