Re: [EXT] [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-06 Thread Bhupesh Sharma
Hello Igor, On Wed, May 6, 2020 at 12:21 PM Igor Russkikh wrote: > > > > > #include > > +#include > > #include > > #include > > #include > > @@ -574,13 +575,13 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, > > __be16 proto, > > #define RX_RING_SIZE

Re: [EXT] [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-06 Thread Igor Russkikh
> #include > +#include > #include > #include > #include > @@ -574,13 +575,13 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, > __be16 proto, > #define RX_RING_SIZE ((u16)BIT(RX_RING_SIZE_POW)) > #define NUM_RX_BDS_MAX (RX_RING_SIZE - 1) > #define

Re: [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
Hi David, On Wed, May 6, 2020 at 2:54 AM David Miller wrote: > > From: Bhupesh Sharma > Date: Wed, 6 May 2020 00:34:40 +0530 > > > -#define NUM_RX_BDS_DEF ((u16)BIT(10) - 1) > > +#define NUM_RX_BDS_DEF ((is_kdump_kernel()) ? ((u16)BIT(6) - > > 1) : ((u16)BIT(10) -

Re: [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread David Miller
From: Bhupesh Sharma Date: Wed, 6 May 2020 00:34:40 +0530 > -#define NUM_RX_BDS_DEF ((u16)BIT(10) - 1) > +#define NUM_RX_BDS_DEF ((is_kdump_kernel()) ? ((u16)BIT(6) - > 1) : ((u16)BIT(10) - 1)) These parenthesis are very excessive and unnecessary. At the very

[PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
Normally kdump kernel(s) run under severe memory constraint with the basic idea being to save the crashdump vmcore reliably when the primary kernel panics/hangs. Currently the qed* ethernet driver ends up consuming a lot of memory in the kdump kernel, leading to kdump kernel panic when one tries