Re: [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-07 Thread Jiri Kosina
On Mon, 6 Mar 2017, David Miller wrote: > > Ah, right you are, thanks. The complete fix is not super trivial, as it > > needs some more surgery to tc_dump_qdisc_root(), tc_dump_tclass_root() and > > qdisc_match_from_root() (see 69012ae42 for some details). > > > > There are two options: > > >

Re: [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-06 Thread David Miller
From: Jiri Kosina Date: Mon, 6 Mar 2017 12:03:38 +0100 (CET) > Ah, right you are, thanks. The complete fix is not super trivial, as it > needs some more surgery to tc_dump_qdisc_root(), tc_dump_tclass_root() and > qdisc_match_from_root() (see 69012ae42 for some details). > > There are two opti

Re: [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-06 Thread Jiri Kosina
On Wed, 1 Mar 2017, David Miller wrote: > > @@ -1066,6 +1066,7 @@ hfsc_change_class(struct Qdisc *sch, u32 classid, u32 > > parentid, > > &pfifo_qdisc_ops, classid); > > if (cl->qdisc == NULL) > > cl->qdisc = &noop_qdisc; > > + qdisc_hash_add(cl

Re: [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-01 Thread David Miller
From: Jiri Kosina Date: Sat, 25 Feb 2017 22:29:09 +0100 (CET) > @@ -1066,6 +1066,7 @@ hfsc_change_class(struct Qdisc *sch, u32 classid, u32 > parentid, > &pfifo_qdisc_ops, classid); > if (cl->qdisc == NULL) > cl->qdisc = &noop_qdisc; > +

[PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-02-25 Thread Jiri Kosina
From: Jiri Kosina The original reason [1] for having hidden qdiscs (potential scalability issues in qdisc_match_from_root() with single linked list in case of large amount of qdiscs) has been invalidated by 59cc1f61f0 ("net: sched: convert qdisc linked list to hashtable"). This allows us for