Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-16 Thread Aleksandr Nogikh
On Thu, Oct 15, 2020 at 10:04 PM Willem de Bruijn wrote: > > On Tue, Oct 13, 2020 at 12:50 PM Jakub Kicinski wrote: > > > > On Tue, 13 Oct 2020 18:59:28 +0300 Aleksandr Nogikh wrote: > > > On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > > > > > > > On Sat, Oct 10, 2020 at 5:14 PM Jakub

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-15 Thread Willem de Bruijn
On Tue, Oct 13, 2020 at 12:50 PM Jakub Kicinski wrote: > > On Tue, 13 Oct 2020 18:59:28 +0300 Aleksandr Nogikh wrote: > > On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > > > > > On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > > > > > > > On Sat, 10 Oct 2020 09:54:57 +0200

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 18:59:28 +0300 Aleksandr Nogikh wrote: > On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > > > On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > > > > > On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > > > > On Sat, Oct 10, 2020 at 1:16 AM Jakub

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-13 Thread Aleksandr Nogikh
On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > > > On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > > > On Sat, Oct 10, 2020 at 1:16 AM Jakub Kicinski wrote: [...] > > > > Could you use skb_extensions for this? > > > > >

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-12 Thread Aleksandr Nogikh
On Mon, 12 Oct 2020 at 10:12, Johannes Berg wrote: [...] > > @@ -233,6 +233,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t > > gfp_mask, > > skb->end = skb->tail + size; > > skb->mac_header = (typeof(skb->mac_header))~0U; > > skb->transport_header =

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-12 Thread Johannes Berg
On Wed, 2020-10-07 at 10:17 +, Aleksandr Nogikh wrote: > > @@ -904,6 +905,10 @@ struct sk_buff { > __u16 network_header; > __u16 mac_header; > > +#ifdef CONFIG_KCOV > + u64 kcov_handle; > +#endif [...] > @@ -233,6

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-12 Thread Dmitry Vyukov
On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > > On Sat, Oct 10, 2020 at 1:16 AM Jakub Kicinski wrote: > > > On Wed, 7 Oct 2020 10:17:25 + Aleksandr Nogikh wrote: > > > > From: Aleksandr Nogikh > > > > > > > > Remote KCOV

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-10 Thread Jakub Kicinski
On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > On Sat, Oct 10, 2020 at 1:16 AM Jakub Kicinski wrote: > > On Wed, 7 Oct 2020 10:17:25 + Aleksandr Nogikh wrote: > > > From: Aleksandr Nogikh > > > > > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > > >

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-10 Thread Dmitry Vyukov
On Sat, Oct 10, 2020 at 1:16 AM Jakub Kicinski wrote: > > On Wed, 7 Oct 2020 10:17:25 + Aleksandr Nogikh wrote: > > From: Aleksandr Nogikh > > > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > > code that is not reachable during normal system call execution. It is

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 10:17:25 + Aleksandr Nogikh wrote: > From: Aleksandr Nogikh > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > code that is not reachable during normal system call execution. It is > especially helpful for fuzzing networking subsystems, where it

[PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-07 Thread Aleksandr Nogikh
From: Aleksandr Nogikh Remote KCOV coverage collection enables coverage-guided fuzzing of the code that is not reachable during normal system call execution. It is especially helpful for fuzzing networking subsystems, where it is common to perform packet handling in separate work queues even for