Re: [External] Re: [PATCH 1/2] nvmet: introduce transport layer keep-alive

2020-10-28 Thread zhenwei pi
On 10/28/20 3:15 PM, Sagi Grimberg wrote: On 10/27/20 5:15 AM, zhenwei pi wrote: In the zero KATO scenario, if initiator crashes without transport layer disconnection, target side would never reclaim resources. A target could start transport layer keep-alive to detect dead connection for the a

Re: [PATCH 1/2] nvmet: introduce transport layer keep-alive

2020-10-28 Thread Sagi Grimberg
On 10/27/20 5:15 AM, zhenwei pi wrote: In the zero KATO scenario, if initiator crashes without transport layer disconnection, target side would never reclaim resources. A target could start transport layer keep-alive to detect dead connection for the admin queue. Not sure why we should worry

[PATCH 1/2] nvmet: introduce transport layer keep-alive

2020-10-27 Thread zhenwei pi
In the zero KATO scenario, if initiator crashes without transport layer disconnection, target side would never reclaim resources. A target could start transport layer keep-alive to detect dead connection for the admin queue. Signed-off-by: zhenwei pi --- drivers/nvme/target/admin-cmd.c | 2 +-