Re: [PATCH 1/2] of: unittest: remove unneeded local return value variables

2018-03-12 Thread Rob Herring
On Fri, Mar 9, 2018 at 7:28 PM, Frank Rowand wrote: > On 03/09/18 16:02, Rob Herring wrote: >> On Thu, Mar 08, 2018 at 02:39:04PM -0800, frowand.l...@gmail.com wrote: >>> From: Frank Rowand >>> >>> A common pattern in many unittest functions is to

Re: [PATCH 1/2] of: unittest: remove unneeded local return value variables

2018-03-12 Thread Rob Herring
On Fri, Mar 9, 2018 at 7:28 PM, Frank Rowand wrote: > On 03/09/18 16:02, Rob Herring wrote: >> On Thu, Mar 08, 2018 at 02:39:04PM -0800, frowand.l...@gmail.com wrote: >>> From: Frank Rowand >>> >>> A common pattern in many unittest functions is to save the return >>> value of a function in a

Re: [PATCH 1/2] of: unittest: remove unneeded local return value variables

2018-03-09 Thread Frank Rowand
On 03/09/18 16:02, Rob Herring wrote: > On Thu, Mar 08, 2018 at 02:39:04PM -0800, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> A common pattern in many unittest functions is to save the return >> value of a function in a local variable, then test the value of

Re: [PATCH 1/2] of: unittest: remove unneeded local return value variables

2018-03-09 Thread Frank Rowand
On 03/09/18 16:02, Rob Herring wrote: > On Thu, Mar 08, 2018 at 02:39:04PM -0800, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> A common pattern in many unittest functions is to save the return >> value of a function in a local variable, then test the value of >> the local variable,

Re: [PATCH 1/2] of: unittest: remove unneeded local return value variables

2018-03-09 Thread Rob Herring
On Thu, Mar 08, 2018 at 02:39:04PM -0800, frowand.l...@gmail.com wrote: > From: Frank Rowand > > A common pattern in many unittest functions is to save the return > value of a function in a local variable, then test the value of > the local variable, without using that

Re: [PATCH 1/2] of: unittest: remove unneeded local return value variables

2018-03-09 Thread Rob Herring
On Thu, Mar 08, 2018 at 02:39:04PM -0800, frowand.l...@gmail.com wrote: > From: Frank Rowand > > A common pattern in many unittest functions is to save the return > value of a function in a local variable, then test the value of > the local variable, without using that return value for any

[PATCH 1/2] of: unittest: remove unneeded local return value variables

2018-03-08 Thread frowand . list
From: Frank Rowand A common pattern in many unittest functions is to save the return value of a function in a local variable, then test the value of the local variable, without using that return value for any further purpose. Remove the local return value variable for

[PATCH 1/2] of: unittest: remove unneeded local return value variables

2018-03-08 Thread frowand . list
From: Frank Rowand A common pattern in many unittest functions is to save the return value of a function in a local variable, then test the value of the local variable, without using that return value for any further purpose. Remove the local return value variable for these cases. A second