Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-14 Thread Stephane Eranian
On Sat, Jul 12, 2014 at 2:01 AM, Andi Kleen wrote: > From: Andi Kleen > > The basic idea is that it does not make sense to list all PEBS > events individually. The list is very long, sometimes outdated > and the hardware doesn't need it. If an event does not support > PEBS it will just not count,

[PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-11 Thread Andi Kleen
From: Andi Kleen The basic idea is that it does not make sense to list all PEBS events individually. The list is very long, sometimes outdated and the hardware doesn't need it. If an event does not support PEBS it will just not count, there is no security issue. This vastly simplifies the PEBS e

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection v2

2014-07-07 Thread Stephane Eranian
On Tue, Jul 8, 2014 at 12:37 AM, Andi Kleen wrote: > From: Andi Kleen > > The basic idea is that it does not make sense to list all PEBS > events individually. The list is very long, sometimes outdated > and the hardware doesn't need it. If an event does not support > PEBS it will just not count,

[PATCH 1/2] perf, x86: Revamp PEBS event selection v2

2014-07-07 Thread Andi Kleen
From: Andi Kleen The basic idea is that it does not make sense to list all PEBS events individually. The list is very long, sometimes outdated and the hardware doesn't need it. If an event does not support PEBS it will just not count, there is no security issue. This vastly simplifies the PEBS e

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-06 Thread Stephane Eranian
On Wed, Jul 2, 2014 at 8:10 PM, Andi Kleen wrote: > On Wed, Jul 02, 2014 at 06:07:31PM +0200, Stephane Eranian wrote: >> On Wed, Jul 2, 2014 at 5:48 PM, Andi Kleen wrote: >> > On Wed, Jul 02, 2014 at 05:44:05PM +0200, Stephane Eranian wrote: >> >> On Wed, Jul 2, 2014 at 5:33 PM, Andi Kleen wrote

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Andi Kleen
> But also, I think we should conditionally allow the filter bits; > possibly with a sysfs file like I had. > > Back when we had to sort that SNB cycles thing it was tedious that Linus > could not just try things. Hmm, the code in your patch to handle it was quite nasty. I don't really see the si

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Andi Kleen
On Wed, Jul 02, 2014 at 06:07:31PM +0200, Stephane Eranian wrote: > On Wed, Jul 2, 2014 at 5:48 PM, Andi Kleen wrote: > > On Wed, Jul 02, 2014 at 05:44:05PM +0200, Stephane Eranian wrote: > >> On Wed, Jul 2, 2014 at 5:33 PM, Andi Kleen wrote: > >> >> No, still needs to be INTEL_ALL_EVENT_CONSTRAI

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Stephane Eranian
On Wed, Jul 2, 2014 at 5:48 PM, Andi Kleen wrote: > On Wed, Jul 02, 2014 at 05:44:05PM +0200, Stephane Eranian wrote: >> On Wed, Jul 2, 2014 at 5:33 PM, Andi Kleen wrote: >> >> No, still needs to be INTEL_ALL_EVENT_CONSTRAINT(0x0, 0x1) >> >> otherwise the get_event_constraint() test I mentioned p

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Andi Kleen
On Wed, Jul 02, 2014 at 05:44:05PM +0200, Stephane Eranian wrote: > On Wed, Jul 2, 2014 at 5:33 PM, Andi Kleen wrote: > >> No, still needs to be INTEL_ALL_EVENT_CONSTRAINT(0x0, 0x1) > >> otherwise the get_event_constraint() test I mentioned previously will > >> fail, event with your ALL_FILTER mas

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Stephane Eranian
On Wed, Jul 2, 2014 at 5:33 PM, Andi Kleen wrote: >> No, still needs to be INTEL_ALL_EVENT_CONSTRAINT(0x0, 0x1) >> otherwise the get_event_constraint() test I mentioned previously will >> fail, event with your ALL_FILTER mask. > > What events should fail? I verified all PEBS events and they work a

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Peter Zijlstra
On Wed, Jul 02, 2014 at 08:34:07AM -0700, Andi Kleen wrote: > On Wed, Jul 02, 2014 at 02:29:02PM +0200, Peter Zijlstra wrote: > > On Fri, Jun 27, 2014 at 04:10:11PM -0700, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > As already discussed earlier in email. > > > > Is an entirely inappropr

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Andi Kleen
On Wed, Jul 02, 2014 at 02:29:02PM +0200, Peter Zijlstra wrote: > On Fri, Jun 27, 2014 at 04:10:11PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > As already discussed earlier in email. > > Is an entirely inappropriate start for a Changelog. Do not assume prior > knowledge. If its releva

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Andi Kleen
> No, still needs to be INTEL_ALL_EVENT_CONSTRAINT(0x0, 0x1) > otherwise the get_event_constraint() test I mentioned previously will > fail, event with your ALL_FILTER mask. What events should fail? I verified all PEBS events and they work as expected. > > - INTEL_EVENT_CONSTRAINT(0xc4, 0xf

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Stephane Eranian
Andi, On Sat, Jun 28, 2014 at 1:10 AM, Andi Kleen wrote: > From: Andi Kleen > > As already discussed earlier in email. > > The basic idea is that it does not make sense to list all PEBS > events individually. The list is very long, sometimes outdated > and the hardware doesn't need it. If an ev

Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-07-02 Thread Peter Zijlstra
On Fri, Jun 27, 2014 at 04:10:11PM -0700, Andi Kleen wrote: > From: Andi Kleen > > As already discussed earlier in email. Is an entirely inappropriate start for a Changelog. Do not assume prior knowledge. If its relevant include it here without reference. pgprcUiTuNF0F.pgp Description: PGP sig

[PATCH 1/2] perf, x86: Revamp PEBS event selection

2014-06-27 Thread Andi Kleen
From: Andi Kleen As already discussed earlier in email. The basic idea is that it does not make sense to list all PEBS events individually. The list is very long, sometimes outdated and the hardware doesn't need it. If an event does not support PEBS it will just not count, there is no security i