Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-04-01 Thread Song Liu
> On Mar 30, 2021, at 8:11 AM, Namhyung Kim wrote: > > On Tue, Mar 30, 2021 at 3:33 PM Song Liu wrote: >>> On Mar 29, 2021, at 4:33 AM, Namhyung Kim wrote: >>> >>> On Mon, Mar 29, 2021 at 2:17 AM Song Liu wrote: > On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > > As we

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-04-01 Thread Stephane Eranian
Hi, I would like to re-emphasize why this patch is important. As Namhyung outlined in his cover message, cgroup monitoring build on top of per-cpu monitoring and offers maximum flexibility by allowing each event to be attached to a single cgroup. Although this is fine when the machines were much

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-30 Thread Namhyung Kim
On Tue, Mar 30, 2021 at 3:33 PM Song Liu wrote: > > On Mar 29, 2021, at 4:33 AM, Namhyung Kim wrote: > > > > On Mon, Mar 29, 2021 at 2:17 AM Song Liu wrote: > >>> On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > >>> > >>> As we can run many jobs (in container) on a big machine, we want to >

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-30 Thread Song Liu
> On Mar 29, 2021, at 4:33 AM, Namhyung Kim wrote: > > On Mon, Mar 29, 2021 at 2:17 AM Song Liu wrote: >>> On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: >>> >>> As we can run many jobs (in container) on a big machine, we want to >>> measure each job's performance during the run. To do

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-29 Thread Namhyung Kim
On Mon, Mar 29, 2021 at 2:17 AM Song Liu wrote: > > On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > > > > As we can run many jobs (in container) on a big machine, we want to > > measure each job's performance during the run. To do that, the > > perf_event can be associated to a cgroup to

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-28 Thread Song Liu
> On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > > As we can run many jobs (in container) on a big machine, we want to > measure each job's performance during the run. To do that, the > perf_event can be associated to a cgroup to measure it only. > > However such cgroup events need to

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-25 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 25, 2021 at 12:55:50AM +, Song Liu escreveu: > > On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > > #ifdef CONFIG_SECURITY > > @@ -780,6 +792,14 @@ struct perf_event { > > #endif /* CONFIG_PERF_EVENTS */ > > }; > > +struct perf_cgroup_node { > > + struct hlist_node

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-24 Thread Namhyung Kim
Hi Song, Thanks for your review! On Thu, Mar 25, 2021 at 9:56 AM Song Liu wrote: > > On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > > > > As we can run many jobs (in container) on a big machine, we want to > > measure each job's performance during the run. To do that, the > > perf_event

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-24 Thread Song Liu
> On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > > As we can run many jobs (in container) on a big machine, we want to > measure each job's performance during the run. To do that, the > perf_event can be associated to a cgroup to measure it only. > > However such cgroup events need to

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-23 Thread Namhyung Kim
Hi Song, On Wed, Mar 24, 2021 at 9:30 AM Song Liu wrote: > > > > > On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > > > > As we can run many jobs (in container) on a big machine, we want to > > measure each job's performance during the run. To do that, the > > perf_event can be associated to

Re: [PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-23 Thread Song Liu
> On Mar 23, 2021, at 9:21 AM, Namhyung Kim wrote: > > As we can run many jobs (in container) on a big machine, we want to > measure each job's performance during the run. To do that, the > perf_event can be associated to a cgroup to measure it only. > > However such cgroup events need to

[PATCH 1/2] perf/core: Share an event with multiple cgroups

2021-03-23 Thread Namhyung Kim
As we can run many jobs (in container) on a big machine, we want to measure each job's performance during the run. To do that, the perf_event can be associated to a cgroup to measure it only. However such cgroup events need to be opened separately and it causes significant overhead in event