Re: [PATCH 1/2] perf: drop unneeded bitmap_zero() in util/header.c

2018-07-25 Thread Arnaldo Carvalho de Melo
Em Sat, Jun 23, 2018 at 10:35:01AM +0300, Yury Norov escreveu: > On top of next-20180622. > > bitmap_zero() is called after bitmap_alloc() in perf code. But > bitmap_alloc() internally uses calloc() which guarantees that allocated > area is zeroed. So following bitmap_zero is unneeded. Drop it. >

Re: [PATCH 1/2] perf: drop unneeded bitmap_zero() in util/header.c

2018-07-25 Thread Arnaldo Carvalho de Melo
Em Sat, Jun 23, 2018 at 10:35:01AM +0300, Yury Norov escreveu: > On top of next-20180622. > > bitmap_zero() is called after bitmap_alloc() in perf code. But > bitmap_alloc() internally uses calloc() which guarantees that allocated > area is zeroed. So following bitmap_zero is unneeded. Drop it. >

Re: [PATCH 1/2] perf: drop unneeded bitmap_zero() in util/header.c

2018-07-24 Thread Yury Norov
On Sat, Jun 23, 2018 at 10:35:01AM +0300, Yury Norov wrote: > On top of next-20180622. > > bitmap_zero() is called after bitmap_alloc() in perf code. But > bitmap_alloc() internally uses calloc() which guarantees that allocated > area is zeroed. So following bitmap_zero is unneeded. Drop it. > >

Re: [PATCH 1/2] perf: drop unneeded bitmap_zero() in util/header.c

2018-07-24 Thread Yury Norov
On Sat, Jun 23, 2018 at 10:35:01AM +0300, Yury Norov wrote: > On top of next-20180622. > > bitmap_zero() is called after bitmap_alloc() in perf code. But > bitmap_alloc() internally uses calloc() which guarantees that allocated > area is zeroed. So following bitmap_zero is unneeded. Drop it. > >

[PATCH 1/2] perf: drop unneeded bitmap_zero() in util/header.c

2018-06-23 Thread Yury Norov
On top of next-20180622. bitmap_zero() is called after bitmap_alloc() in perf code. But bitmap_alloc() internally uses calloc() which guarantees that allocated area is zeroed. So following bitmap_zero is unneeded. Drop it. This happened because of confusing name for bitmap allocator. It should

[PATCH 1/2] perf: drop unneeded bitmap_zero() in util/header.c

2018-06-23 Thread Yury Norov
On top of next-20180622. bitmap_zero() is called after bitmap_alloc() in perf code. But bitmap_alloc() internally uses calloc() which guarantees that allocated area is zeroed. So following bitmap_zero is unneeded. Drop it. This happened because of confusing name for bitmap allocator. It should