Re: [PATCH 1/2] perf annotate: handle ins parsing failures

2015-01-19 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 18, 2015 at 08:00:20PM +0100, Rabin Vincent escreveu: > Don't use the ins's ->sncprintf() if the parsing failed. > > For example, this fixes the display of "imul %edx". Without this patch: > >| imul (null),(null) > > After this patch: > >| imul %edx

Re: [PATCH 1/2] perf annotate: handle ins parsing failures

2015-01-19 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 18, 2015 at 08:00:20PM +0100, Rabin Vincent escreveu: Don't use the ins's -sncprintf() if the parsing failed. For example, this fixes the display of imul %edx. Without this patch: | imul (null),(null) After this patch: | imul %edx Thanks, both

[PATCH 1/2] perf annotate: handle ins parsing failures

2015-01-18 Thread Rabin Vincent
Don't use the ins's ->sncprintf() if the parsing failed. For example, this fixes the display of "imul %edx". Without this patch: | imul (null),(null) After this patch: | imul %edx Signed-off-by: Rabin Vincent --- tools/perf/util/annotate.c | 9 + 1 file

[PATCH 1/2] perf annotate: handle ins parsing failures

2015-01-18 Thread Rabin Vincent
Don't use the ins's -sncprintf() if the parsing failed. For example, this fixes the display of imul %edx. Without this patch: | imul (null),(null) After this patch: | imul %edx Signed-off-by: Rabin Vincent ra...@rab.in --- tools/perf/util/annotate.c | 9 +