Re: [PATCH 1/2] perf callchain: Create an address space per thread

2014-09-26 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 23, 2014 at 09:49:22PM +0900, Namhyung Kim escreveu: > On Tue, Sep 23, 2014 at 9:24 PM, Jiri Olsa wrote: > >> list_add(&comm->list, &thread->comm_list); > >> + > >> + if (unwind__prepare_access(thread) < 0) { > > > > you could call list_add below this call and

Re: [PATCH 1/2] perf callchain: Create an address space per thread

2014-09-23 Thread Namhyung Kim
Hi Jiri, On Tue, Sep 23, 2014 at 9:24 PM, Jiri Olsa wrote: > On Tue, Sep 23, 2014 at 03:30:27PM +0900, Namhyung Kim wrote: >> The unw_addr_space_t in libunwind represents an address space to be >> used for stack unwinding. It doesn't need to be create/destory >> everytime to unwind callchain (as

Re: [PATCH 1/2] perf callchain: Create an address space per thread

2014-09-23 Thread Jiri Olsa
On Tue, Sep 23, 2014 at 03:30:27PM +0900, Namhyung Kim wrote: > The unw_addr_space_t in libunwind represents an address space to be > used for stack unwinding. It doesn't need to be create/destory > everytime to unwind callchain (as in get_entries) and can have a same > lifetime as thread (unless

[PATCH 1/2] perf callchain: Create an address space per thread

2014-09-22 Thread Namhyung Kim
The unw_addr_space_t in libunwind represents an address space to be used for stack unwinding. It doesn't need to be create/destory everytime to unwind callchain (as in get_entries) and can have a same lifetime as thread (unless exec called). So move the address space construction/destruction logi