Re: [PATCH 1/2] perf tests: Factor out fake_setup_machine()

2014-04-28 Thread Jiri Olsa
On Mon, Apr 28, 2014 at 08:59:42AM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Fri, 25 Apr 2014 14:27:34 +0200, Jiri Olsa wrote: > > On Fri, Apr 25, 2014 at 12:28:13PM +0900, Namhyung Kim wrote: > >> The fake_setup_machine() is for setting up a environment for testing > >> various hists operation

Re: [PATCH 1/2] perf tests: Factor out fake_setup_machine()

2014-04-27 Thread Namhyung Kim
Hi Jiri, On Fri, 25 Apr 2014 14:27:34 +0200, Jiri Olsa wrote: > On Fri, Apr 25, 2014 at 12:28:13PM +0900, Namhyung Kim wrote: >> The fake_setup_machine() is for setting up a environment for testing >> various hists operations. As it'll be used for other test cases it'd >> better factoring it out.

Re: [PATCH 1/2] perf tests: Factor out fake_setup_machine()

2014-04-25 Thread Jiri Olsa
On Fri, Apr 25, 2014 at 12:28:13PM +0900, Namhyung Kim wrote: > The fake_setup_machine() is for setting up a environment for testing > various hists operations. As it'll be used for other test cases it'd > better factoring it out. looks like print_hists could be in hists_common.c as well.. within

[PATCH 1/2] perf tests: Factor out fake_setup_machine()

2014-04-24 Thread Namhyung Kim
The fake_setup_machine() is for setting up a environment for testing various hists operations. As it'll be used for other test cases it'd better factoring it out. Signed-off-by: Namhyung Kim --- tools/perf/Makefile.perf| 1 + tools/perf/tests/hists_common.c | 148 +