Em Mon, Aug 11, 2014 at 04:38:17PM +0900, Namhyung Kim escreveu:
> On Fri, 1 Aug 2014 17:15:38 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Aug 01, 2014 at 08:38:02AM +0900, Namhyung Kim escreveu:
> >> On Thu, 31 Jul 2014 09:26:21 -0300, Arnaldo Carvalho de Melo wrote:
> >> > Em Thu, Jul 31,
Hi Arnaldo,
On Fri, 1 Aug 2014 17:15:38 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 01, 2014 at 08:38:02AM +0900, Namhyung Kim escreveu:
>> Hi Arnaldo,
>>
>> On Thu, 31 Jul 2014 09:26:21 -0300, Arnaldo Carvalho de Melo wrote:
>> > Em Thu, Jul 31, 2014 at 01:25:52PM +0900, Namhyung Kim es
Em Fri, Aug 01, 2014 at 08:38:02AM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
>
> On Thu, 31 Jul 2014 09:26:21 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jul 31, 2014 at 01:25:52PM +0900, Namhyung Kim escreveu:
> >> Are you still against my approach - adding '/' at the end of the symfs
>
Hi Arnaldo,
On Thu, 31 Jul 2014 09:26:21 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jul 31, 2014 at 01:25:52PM +0900, Namhyung Kim escreveu:
>> Are you still against my approach - adding '/' at the end of the symfs
>> string itself? It seems that mine is simpler and shorter.
>
> Yes, I am.
Em Thu, Jul 31, 2014 at 01:25:52PM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
>
> On Wed, 30 Jul 2014 17:55:21 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Jul 30, 2014 at 12:19:32PM -0300, Arnaldo Carvalho de Melo escreveu:
> >> Em Wed, Jul 30, 2014 at 08:52:36AM +0900, Namhyung Kim escrev
Hi Arnaldo,
On Wed, 30 Jul 2014 17:55:21 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 30, 2014 at 12:19:32PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Jul 30, 2014 at 08:52:36AM +0900, Namhyung Kim escreveu:
>> > I also thought about that way first but changed my mind to the cur
On 7/30/14, 2:55 PM, Arnaldo Carvalho de Melo wrote:
@@ -143,6 +144,14 @@ struct symbol_conf {
};
extern struct symbol_conf symbol_conf;
+
+static inline int __symbol__join_symfs(char *bf, size_t size, const char *path)
+{
+ return path__join(bf, size, symbol_conf.symfs, path);
+}
+
+#
Em Wed, Jul 30, 2014 at 12:19:32PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Jul 30, 2014 at 08:52:36AM +0900, Namhyung Kim escreveu:
> > I also thought about that way first but changed my mind to the current
> > approach because I don't want to change current behavior.
>
> > I worried a
Em Wed, Jul 30, 2014 at 08:52:36AM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
>
> On Tue, 29 Jul 2014 09:33:05 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jul 29, 2014 at 02:02:46PM +0900, Minchan Kim escreveu:
> >> On Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim wrote:
> >> > Minch
Hi Arnaldo,
On Tue, 29 Jul 2014 09:33:05 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 29, 2014 at 02:02:46PM +0900, Minchan Kim escreveu:
>> On Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim wrote:
>> > Minchan reported that perf failed to load vmlinux if --symfs argument
>> > doesn't
Em Tue, Jul 29, 2014 at 10:26:57PM +0900, Minchan Kim escreveu:
> On Tue, Jul 29, 2014 at 09:33:05AM -0300, Arnaldo Carvalho de Melo wrote:
> > Can you please try the patch below instead?
>
> Tested. It works.
> And I'd like to say that [2/2] in patchset is handy to me.
Ok, here it is, refreshed,
On 7/29/14, 6:33 AM, Arnaldo Carvalho de Melo wrote:
David, was there any reason not to do it like done in this patch?
I feel like we did at one point.
http://www.spinics.net/lists/linux-perf-users/msg00252.html
So my original rootfs patch did use '/' after the path.
Incarnation as symfs wh
Em Tue, Jul 29, 2014 at 10:26:57PM +0900, Minchan Kim escreveu:
> Hello,
>
> On Tue, Jul 29, 2014 at 09:33:05AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jul 29, 2014 at 02:02:46PM +0900, Minchan Kim escreveu:
> > > On Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim wrote:
> > > > Min
Hello,
On Tue, Jul 29, 2014 at 09:33:05AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 29, 2014 at 02:02:46PM +0900, Minchan Kim escreveu:
> > On Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim wrote:
> > > Minchan reported that perf failed to load vmlinux if --symfs argument
> > > doe
Em Tue, Jul 29, 2014 at 02:02:46PM +0900, Minchan Kim escreveu:
> On Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim wrote:
> > Minchan reported that perf failed to load vmlinux if --symfs argument
> > doesn't end with '/' character. So make sure that the symfs always
> > ends with the '/'.
>
On Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim wrote:
> Minchan reported that perf failed to load vmlinux if --symfs argument
> doesn't end with '/' character. So make sure that the symfs always
> ends with the '/'.
>
> Reported-by: Minchan Kim
> Signed-off-by: Namhyung Kim
Both patche
Hi Arnaldo,
On Fri, 25 Jul 2014 10:15:21 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim escreveu:
>> Minchan reported that perf failed to load vmlinux if --symfs argument
>> doesn't end with '/' character. So make sure that the symfs always
>> ends
Em Fri, Jul 25, 2014 at 10:31:47AM +0900, Namhyung Kim escreveu:
> Minchan reported that perf failed to load vmlinux if --symfs argument
> doesn't end with '/' character. So make sure that the symfs always
> ends with the '/'.
I don't think this is the right way of doing this, users of
symbol_con
Minchan reported that perf failed to load vmlinux if --symfs argument
doesn't end with '/' character. So make sure that the symfs always
ends with the '/'.
Reported-by: Minchan Kim
Signed-off-by: Namhyung Kim
---
tools/perf/util/symbol.c | 41 +
1 file c
19 matches
Mail list logo
