Re: [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-04 Thread Caesar Wang
Hi Kishon & Shawn, As the bug had tracked on https://issuetracker.google.com/71561742. In some cases, the mmc phy power on failed during booting up. The log as below: ... [   2.375333] rockchip_emmc_phy_power: caldone timeout. [    2.377815] phy phy-ff77.syscon:phy@f780.4: phy poweron

Re: [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-04 Thread Caesar Wang
Hi Kishon & Shawn, As the bug had tracked on https://issuetracker.google.com/71561742. In some cases, the mmc phy power on failed during booting up. The log as below: ... [   2.375333] rockchip_emmc_phy_power: caldone timeout. [    2.377815] phy phy-ff77.syscon:phy@f780.4: phy poweron

Re: [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-04 Thread Ziyuan
hi , On 01/02/2018 10:21 AM, Shawn Lin wrote: It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin Tested-by: Ziyuan Xu On the Firefly RK3399 board. Thanks. -- Ziyuan

Re: [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-04 Thread Ziyuan
hi , On 01/02/2018 10:21 AM, Shawn Lin wrote: It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin Tested-by: Ziyuan Xu On the Firefly RK3399 board. Thanks. -- Ziyuan Xu

[PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-01 Thread Shawn Lin
It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

2018-01-01 Thread Shawn Lin
It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin --- drivers/phy/rockchip/phy-rockchip-emmc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git