Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-09 Thread Paul E. McKenney
On Wed, Sep 09, 2015 at 02:39:50PM +0200, Petr Mladek wrote: > On Tue 2015-09-08 12:59:15, Paul E. McKenney wrote: > > On Mon, Sep 07, 2015 at 04:58:27PM +0200, Petr Mladek wrote: > > > On Fri 2015-09-04 16:24:22, Paul E. McKenney wrote: > > > > On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-09 Thread Petr Mladek
On Tue 2015-09-08 12:59:15, Paul E. McKenney wrote: > On Mon, Sep 07, 2015 at 04:58:27PM +0200, Petr Mladek wrote: > > On Fri 2015-09-04 16:24:22, Paul E. McKenney wrote: > > > On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr Mladek wrote: [...] > > > diff --git a/kernel/rcu/tree.c

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-09 Thread Petr Mladek
On Tue 2015-09-08 12:59:15, Paul E. McKenney wrote: > On Mon, Sep 07, 2015 at 04:58:27PM +0200, Petr Mladek wrote: > > On Fri 2015-09-04 16:24:22, Paul E. McKenney wrote: > > > On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr Mladek wrote: [...] > > > diff --git a/kernel/rcu/tree.c

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-09 Thread Paul E. McKenney
On Wed, Sep 09, 2015 at 02:39:50PM +0200, Petr Mladek wrote: > On Tue 2015-09-08 12:59:15, Paul E. McKenney wrote: > > On Mon, Sep 07, 2015 at 04:58:27PM +0200, Petr Mladek wrote: > > > On Fri 2015-09-04 16:24:22, Paul E. McKenney wrote: > > > > On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-08 Thread Paul E. McKenney
On Mon, Sep 07, 2015 at 04:58:27PM +0200, Petr Mladek wrote: > On Fri 2015-09-04 16:24:22, Paul E. McKenney wrote: > > On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr Mladek wrote: > > > The value of "fqs_state" in struct rcu_state is always RCU_GP_IDLE. > > > > > > The real state is stored in a

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-08 Thread Paul E. McKenney
On Mon, Sep 07, 2015 at 04:58:27PM +0200, Petr Mladek wrote: > On Fri 2015-09-04 16:24:22, Paul E. McKenney wrote: > > On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr Mladek wrote: > > > The value of "fqs_state" in struct rcu_state is always RCU_GP_IDLE. > > > > > > The real state is stored in a

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-07 Thread Petr Mladek
On Fri 2015-09-04 16:24:22, Paul E. McKenney wrote: > On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr Mladek wrote: > > The value of "fqs_state" in struct rcu_state is always RCU_GP_IDLE. > > > > The real state is stored in a local variable in rcu_gp_kthread(). > > It is modified by rcu_gp_fqs()

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-07 Thread Petr Mladek
On Fri 2015-09-04 16:24:22, Paul E. McKenney wrote: > On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr Mladek wrote: > > The value of "fqs_state" in struct rcu_state is always RCU_GP_IDLE. > > > > The real state is stored in a local variable in rcu_gp_kthread(). > > It is modified by rcu_gp_fqs()

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-04 Thread Paul E. McKenney
On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr Mladek wrote: > The value of "fqs_state" in struct rcu_state is always RCU_GP_IDLE. > > The real state is stored in a local variable in rcu_gp_kthread(). > It is modified by rcu_gp_fqs() via parameter and return value. > But the actual value is never

[PATCH 1/2] rcu: Show the real fqs_state

2015-09-04 Thread Petr Mladek
The value of "fqs_state" in struct rcu_state is always RCU_GP_IDLE. The real state is stored in a local variable in rcu_gp_kthread(). It is modified by rcu_gp_fqs() via parameter and return value. But the actual value is never stored to rsp->fqs_state. The result is that print_one_rcu_state()

[PATCH 1/2] rcu: Show the real fqs_state

2015-09-04 Thread Petr Mladek
The value of "fqs_state" in struct rcu_state is always RCU_GP_IDLE. The real state is stored in a local variable in rcu_gp_kthread(). It is modified by rcu_gp_fqs() via parameter and return value. But the actual value is never stored to rsp->fqs_state. The result is that print_one_rcu_state()

Re: [PATCH 1/2] rcu: Show the real fqs_state

2015-09-04 Thread Paul E. McKenney
On Fri, Sep 04, 2015 at 02:11:29PM +0200, Petr Mladek wrote: > The value of "fqs_state" in struct rcu_state is always RCU_GP_IDLE. > > The real state is stored in a local variable in rcu_gp_kthread(). > It is modified by rcu_gp_fqs() via parameter and return value. > But the actual value is never