Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe()

2016-02-03 Thread Mark Brown
On Fri, Jan 29, 2016 at 05:25:28PM +0100, Harald Geyer wrote: > Mark Brown writes: > > On Thu, Jan 28, 2016 at 07:55:17PM +, Harald Geyer wrote: > > > The data structures either have been copied in > > > of_get_gpio_regulator_config() already or are part of platform data, > > > which we keep a

Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe()

2016-01-29 Thread Harald Geyer
Mark Brown writes: > On Thu, Jan 28, 2016 at 07:55:17PM +, Harald Geyer wrote: > > The data structures either have been copied in > > of_get_gpio_regulator_config() already or are part of platform data, > > which we keep a pointer to for the life time of the device anyway. > > The point of thi

Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe()

2016-01-28 Thread Mark Brown
On Thu, Jan 28, 2016 at 07:55:17PM +, Harald Geyer wrote: > The data structures either have been copied in > of_get_gpio_regulator_config() already or are part of platform data, > which we keep a pointer to for the life time of the device anyway. The point of this code is to avoid referring to

[PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe()

2016-01-28 Thread Harald Geyer
The data structures either have been copied in of_get_gpio_regulator_config() already or are part of platform data, which we keep a pointer to for the life time of the device anyway. As a side effect this fixes the cleanup pathes if probe() fails. Signed-off-by: Harald Geyer --- drivers/regulat