Re: [PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread Kees Cook
On Thu, Dec 6, 2018 at 10:26 AM David Abdurachmanov wrote: > > On Thu, Dec 6, 2018 at 5:52 PM Kees Cook wrote: > > > > On Thu, Dec 6, 2018 at 7:02 AM David Abdurachmanov > > wrote: > > > The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). > > > > Can you add support to tools/testing/sel

Re: [PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread David Abdurachmanov
On Thu, Dec 6, 2018 at 5:52 PM Kees Cook wrote: > > On Thu, Dec 6, 2018 at 7:02 AM David Abdurachmanov > wrote: > > The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). > > Can you add support to tools/testing/selftests/seccomp/seccomp_bpf.c > as well? That selftest finds a lot of weird c

Re: [PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread David Abdurachmanov
On Thu, Dec 6, 2018 at 6:07 PM Kees Cook wrote: > > On Thu, Dec 6, 2018 at 7:02 AM David Abdurachmanov > wrote: > > The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). > > I built this against linux-next but it's missing seccomp.h. Was that > accidentally left out of the commit? > > >

Re: [PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread David Abdurachmanov
On Thu, Dec 6, 2018 at 5:52 PM Kees Cook wrote: > > On Thu, Dec 6, 2018 at 7:02 AM David Abdurachmanov > wrote: > > The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). > > Can you add support to tools/testing/selftests/seccomp/seccomp_bpf.c > as well? That selftest finds a lot of weird c

Re: [PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread David Abdurachmanov
On Thu, Dec 6, 2018 at 5:47 PM Kees Cook wrote: > > On Thu, Dec 6, 2018 at 7:02 AM David Abdurachmanov > wrote: > > > > The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). > > > > Signed-off-by: David Abdurachmanov > > --- > > arch/riscv/Kconfig | 14 ++ >

Re: [PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread Kees Cook
On Thu, Dec 6, 2018 at 7:02 AM David Abdurachmanov wrote: > The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). I built this against linux-next but it's missing seccomp.h. Was that accidentally left out of the commit? CC arch/riscv/kernel/asm-offsets.s In file included from ./in

Re: [PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread Kees Cook
On Thu, Dec 6, 2018 at 7:02 AM David Abdurachmanov wrote: > The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). Can you add support to tools/testing/selftests/seccomp/seccomp_bpf.c as well? That selftest finds a lot of weird corner-cases... > diff --git a/arch/riscv/include/asm/thread_i

Re: [PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread Kees Cook
On Thu, Dec 6, 2018 at 7:02 AM David Abdurachmanov wrote: > > The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). > > Signed-off-by: David Abdurachmanov > --- > arch/riscv/Kconfig | 14 ++ > arch/riscv/include/asm/thread_info.h | 5 - > arch/riscv/kern

[PATCH 1/2] riscv: add support for SECCOMP incl. filters

2018-12-06 Thread David Abdurachmanov
The patch adds support for SECCOMP and SECCOMP_FILTER (BPF). Signed-off-by: David Abdurachmanov --- arch/riscv/Kconfig | 14 ++ arch/riscv/include/asm/thread_info.h | 5 - arch/riscv/kernel/entry.S| 27 +-- arch/riscv/kernel/