Re: [PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-08-19 Thread Maciej W. Rozycki
On Wed, 5 Aug 2020, Palmer Dabbelt wrote: > > I can push linux-next through regression-testing with RISC-V gdbserver > > and/or native GDB if that would help. This is also used with core dumps, > > but honestly I don't know what state RISC-V support is in in the BFD/GDB's > > core dump

Re: [PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-08-05 Thread Palmer Dabbelt
On Wed, 05 Aug 2020 03:25:11 PDT (-0700), ma...@wdc.com wrote: On Wed, 5 Aug 2020, Al Viro wrote: > I'm not sure I understand what you're saying, but given that branch replaces > all of this I guess it's best to just do nothing on our end here? It doesn't replace ->put() (for now); it _does_

Re: [PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-08-05 Thread Maciej W. Rozycki
On Wed, 5 Aug 2020, Al Viro wrote: > > I'm not sure I understand what you're saying, but given that branch replaces > > all of this I guess it's best to just do nothing on our end here? > > It doesn't replace ->put() (for now); it _does_ replace ->get() and AFAICS the > replacement is much

Re: [PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-08-04 Thread Palmer Dabbelt
On Tue, 04 Aug 2020 19:48:07 PDT (-0700), v...@zeniv.linux.org.uk wrote: On Tue, Aug 04, 2020 at 07:20:05PM -0700, Palmer Dabbelt wrote: On Tue, 04 Aug 2020 19:07:45 PDT (-0700), v...@zeniv.linux.org.uk wrote: > On Tue, Aug 04, 2020 at 07:01:01PM -0700, Palmer Dabbelt wrote: > > > > We

Re: [PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-08-04 Thread Al Viro
On Tue, Aug 04, 2020 at 07:20:05PM -0700, Palmer Dabbelt wrote: > On Tue, 04 Aug 2020 19:07:45 PDT (-0700), v...@zeniv.linux.org.uk wrote: > > On Tue, Aug 04, 2020 at 07:01:01PM -0700, Palmer Dabbelt wrote: > > > > > > We currently have @start_pos fixed at 0 across all calls, which works as > > >

Re: [PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-08-04 Thread Palmer Dabbelt
On Tue, 04 Aug 2020 19:07:45 PDT (-0700), v...@zeniv.linux.org.uk wrote: On Tue, Aug 04, 2020 at 07:01:01PM -0700, Palmer Dabbelt wrote: > We currently have @start_pos fixed at 0 across all calls, which works as > a result of the implementation, in particular because we have no padding >

Re: [PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-08-04 Thread Al Viro
On Tue, Aug 04, 2020 at 07:01:01PM -0700, Palmer Dabbelt wrote: > > We currently have @start_pos fixed at 0 across all calls, which works as > > a result of the implementation, in particular because we have no padding > > between the FP general registers and the FP control and status register, >

Re: [PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-08-04 Thread Palmer Dabbelt
On Thu, 23 Jul 2020 16:22:15 PDT (-0700), ma...@wdc.com wrote: Adjust the calls to `user_regset_copyout' and `user_regset_copyin' in `riscv_fpr_get' and `riscv_fpr_set' respectively so as to use @start_pos and @end_pos according to API documentation in , that is to point at the beginning and the

[PATCH 1/2] riscv: ptrace: Use the correct API for `fcsr' access

2020-07-23 Thread Maciej W. Rozycki
Adjust the calls to `user_regset_copyout' and `user_regset_copyin' in `riscv_fpr_get' and `riscv_fpr_set' respectively so as to use @start_pos and @end_pos according to API documentation in , that is to point at the beginning and the end respectively of the data chunk to be copied. Update