Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-10-02 Thread Greg Kroah-Hartman
On Sat, Sep 29, 2018 at 04:04:48PM +0200, Andreas Färber wrote: > Hi Phil and Greg, > > Am 12.09.18 um 16:31 schrieb Phil Elwell: > > The SC16IS752 is a dual-channel device. The two channels are largely > > independent, but the IRQ signals are wired together as an open-drain, > > active low

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-10-02 Thread Greg Kroah-Hartman
On Sat, Sep 29, 2018 at 04:04:48PM +0200, Andreas Färber wrote: > Hi Phil and Greg, > > Am 12.09.18 um 16:31 schrieb Phil Elwell: > > The SC16IS752 is a dual-channel device. The two channels are largely > > independent, but the IRQ signals are wired together as an open-drain, > > active low

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-29 Thread Andreas Färber
Hi Phil and Greg, Am 12.09.18 um 16:31 schrieb Phil Elwell: > The SC16IS752 is a dual-channel device. The two channels are largely > independent, but the IRQ signals are wired together as an open-drain, > active low signal which will be driven low while either of the > channels requires

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-29 Thread Andreas Färber
Hi Phil and Greg, Am 12.09.18 um 16:31 schrieb Phil Elwell: > The SC16IS752 is a dual-channel device. The two channels are largely > independent, but the IRQ signals are wired together as an open-drain, > active low signal which will be driven low while either of the > channels requires

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-18 Thread Rogier Wolff
On Tue, Sep 18, 2018 at 02:13:15PM +0100, Phil Elwell wrote: > I could add a limit on the number of iterations, but if the limit is ever hit, > leading to an early exit, the port is basically dead because it will never > receive another interrupt. Especially if you print something like: ": Too

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-18 Thread Rogier Wolff
On Tue, Sep 18, 2018 at 02:13:15PM +0100, Phil Elwell wrote: > I could add a limit on the number of iterations, but if the limit is ever hit, > leading to an early exit, the port is basically dead because it will never > receive another interrupt. Especially if you print something like: ": Too

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 18, 2018 at 02:13:15PM +0100, Phil Elwell wrote: > Hi Greg, > > On 18/09/2018 14:02, Greg Kroah-Hartman wrote: > > On Wed, Sep 12, 2018 at 03:31:55PM +0100, Phil Elwell wrote: > >> The SC16IS752 is a dual-channel device. The two channels are largely > >> independent, but the IRQ

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 18, 2018 at 02:13:15PM +0100, Phil Elwell wrote: > Hi Greg, > > On 18/09/2018 14:02, Greg Kroah-Hartman wrote: > > On Wed, Sep 12, 2018 at 03:31:55PM +0100, Phil Elwell wrote: > >> The SC16IS752 is a dual-channel device. The two channels are largely > >> independent, but the IRQ

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-18 Thread Phil Elwell
Hi Greg, On 18/09/2018 14:02, Greg Kroah-Hartman wrote: > On Wed, Sep 12, 2018 at 03:31:55PM +0100, Phil Elwell wrote: >> The SC16IS752 is a dual-channel device. The two channels are largely >> independent, but the IRQ signals are wired together as an open-drain, >> active low signal which will

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-18 Thread Phil Elwell
Hi Greg, On 18/09/2018 14:02, Greg Kroah-Hartman wrote: > On Wed, Sep 12, 2018 at 03:31:55PM +0100, Phil Elwell wrote: >> The SC16IS752 is a dual-channel device. The two channels are largely >> independent, but the IRQ signals are wired together as an open-drain, >> active low signal which will

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-18 Thread Greg Kroah-Hartman
On Wed, Sep 12, 2018 at 03:31:55PM +0100, Phil Elwell wrote: > The SC16IS752 is a dual-channel device. The two channels are largely > independent, but the IRQ signals are wired together as an open-drain, > active low signal which will be driven low while either of the > channels requires

Re: [PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-18 Thread Greg Kroah-Hartman
On Wed, Sep 12, 2018 at 03:31:55PM +0100, Phil Elwell wrote: > The SC16IS752 is a dual-channel device. The two channels are largely > independent, but the IRQ signals are wired together as an open-drain, > active low signal which will be driven low while either of the > channels requires

[PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-12 Thread Phil Elwell
The SC16IS752 is a dual-channel device. The two channels are largely independent, but the IRQ signals are wired together as an open-drain, active low signal which will be driven low while either of the channels requires attention, which can be for significant periods of time until operations

[PATCH 1/2] sc16is7xx: Fix for multi-channel stall

2018-09-12 Thread Phil Elwell
The SC16IS752 is a dual-channel device. The two channels are largely independent, but the IRQ signals are wired together as an open-drain, active low signal which will be driven low while either of the channels requires attention, which can be for significant periods of time until operations