Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-13 Thread Juri Lelli
On 13/02/17 09:59, Steven Rostedt wrote: > On Mon, 13 Feb 2017 12:10:25 +0100 > Peter Zijlstra wrote: > > > > I've interpreted this as: > > > > Reviewed-by: Luca Abeni > > > > Holler if you disagree. > > You can add mine too. I put in a lot

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-13 Thread Juri Lelli
On 13/02/17 09:59, Steven Rostedt wrote: > On Mon, 13 Feb 2017 12:10:25 +0100 > Peter Zijlstra wrote: > > > > I've interpreted this as: > > > > Reviewed-by: Luca Abeni > > > > Holler if you disagree. > > You can add mine too. I put in a lot of trace_printk()s and it all > appears to be

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-13 Thread Steven Rostedt
On Mon, 13 Feb 2017 12:10:25 +0100 Peter Zijlstra wrote: > I've interpreted this as: > > Reviewed-by: Luca Abeni > > Holler if you disagree. You can add mine too. I put in a lot of trace_printk()s and it all appears to be exactly as Daniel

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-13 Thread Steven Rostedt
On Mon, 13 Feb 2017 12:10:25 +0100 Peter Zijlstra wrote: > I've interpreted this as: > > Reviewed-by: Luca Abeni > > Holler if you disagree. You can add mine too. I put in a lot of trace_printk()s and it all appears to be exactly as Daniel describes. Reviewed-by: Steven Rostedt (VMware)

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-13 Thread Peter Zijlstra
On Sat, Feb 11, 2017 at 08:12:37AM +0100, luca abeni wrote: > Hi Daniel, > > On Fri, 10 Feb 2017 20:48:10 +0100 > Daniel Bristot de Oliveira wrote: > > [...] > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index 70ef2b1..3c94d85 100644 > > ---

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-13 Thread Peter Zijlstra
On Sat, Feb 11, 2017 at 08:12:37AM +0100, luca abeni wrote: > Hi Daniel, > > On Fri, 10 Feb 2017 20:48:10 +0100 > Daniel Bristot de Oliveira wrote: > > [...] > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index 70ef2b1..3c94d85 100644 > > --- a/kernel/sched/deadline.c >

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-10 Thread luca abeni
Hi Daniel, On Fri, 10 Feb 2017 20:48:10 +0100 Daniel Bristot de Oliveira wrote: [...] > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 70ef2b1..3c94d85 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -505,10 +505,15 @@

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-10 Thread luca abeni
Hi Daniel, On Fri, 10 Feb 2017 20:48:10 +0100 Daniel Bristot de Oliveira wrote: [...] > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 70ef2b1..3c94d85 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -505,10 +505,15 @@ static void

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-10 Thread Steven Rostedt
On Fri, 10 Feb 2017 20:48:10 +0100 Daniel Bristot de Oliveira wrote: > Currently, the replenishment timer is set to fire at the deadline > of a task. Although that works for implicit deadline tasks because the > deadline is equals to the begin of the next period, that is not

Re: [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-10 Thread Steven Rostedt
On Fri, 10 Feb 2017 20:48:10 +0100 Daniel Bristot de Oliveira wrote: > Currently, the replenishment timer is set to fire at the deadline > of a task. Although that works for implicit deadline tasks because the > deadline is equals to the begin of the next period, that is not correct > for

[PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-10 Thread Daniel Bristot de Oliveira
Currently, the replenishment timer is set to fire at the deadline of a task. Although that works for implicit deadline tasks because the deadline is equals to the begin of the next period, that is not correct for constrained deadline tasks (deadline < period). For instance: f.c: ---

[PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period

2017-02-10 Thread Daniel Bristot de Oliveira
Currently, the replenishment timer is set to fire at the deadline of a task. Although that works for implicit deadline tasks because the deadline is equals to the begin of the next period, that is not correct for constrained deadline tasks (deadline < period). For instance: f.c: ---