Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-17 Thread Kirill Tkhai
Hi, Mike, В Чт, 12/06/2014 в 04:05 +0200, Mike Galbraith пишет: > On Wed, 2014-06-11 at 23:33 +0400, Kirill Tkhai wrote: > > В Ср, 11/06/2014 в 17:43 +0400, Kirill Tkhai пишет: > > > > > > 11.06.2014, 17:15, "Srikar Dronamraju" : > > > >>> * Kirill Tkhai [2014-06-11 13:52:10]: > > > Cur

Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Mike Galbraith
On Wed, 2014-06-11 at 23:33 +0400, Kirill Tkhai wrote: > В Ср, 11/06/2014 в 17:43 +0400, Kirill Tkhai пишет: > > > > 11.06.2014, 17:15, "Srikar Dronamraju" : > > >>> * Kirill Tkhai [2014-06-11 13:52:10]: > > Currently migrate_tasks() skips throttled tasks, > > because they are not

Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Kirill Tkhai
В Ср, 11/06/2014 в 17:43 +0400, Kirill Tkhai пишет: > > 11.06.2014, 17:15, "Srikar Dronamraju" : > >>> * Kirill Tkhai [2014-06-11 13:52:10]: > Currently migrate_tasks() skips throttled tasks, > because they are not pickable by pick_next_task(). > >>> Before migrate_tasks() is call

Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Kirill Tkhai
11.06.2014, 17:15, "Srikar Dronamraju" : >>>  * Kirill Tkhai [2014-06-11 13:52:10]:   Currently migrate_tasks() skips throttled tasks,   because they are not pickable by pick_next_task(). >>>  Before migrate_tasks() is called, we do call set_rq_offline(), in >>>  migration_call(). >>>

Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Srikar Dronamraju
> > * Kirill Tkhai [2014-06-11 13:52:10]: > >>  Currently migrate_tasks() skips throttled tasks, > >>  because they are not pickable by pick_next_task(). > > > > Before migrate_tasks() is called, we do call set_rq_offline(), in > > migration_call(). > > > > Shouldnt this take care of unthrottling

Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Kirill Tkhai
11.06.2014, 15:24, "Srikar Dronamraju" : > * Kirill Tkhai [2014-06-11 13:52:10]: >>  Currently migrate_tasks() skips throttled tasks, >>  because they are not pickable by pick_next_task(). > > Before migrate_tasks() is called, we do call set_rq_offline(), in > migration_call(). > > Shouldnt this t

Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Srikar Dronamraju
* Kirill Tkhai [2014-06-11 13:52:10]: > > Currently migrate_tasks() skips throttled tasks, > because they are not pickable by pick_next_task(). > Before migrate_tasks() is called, we do call set_rq_offline(), in migration_call(). Shouldnt this take care of unthrottling the tasks and making su

Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Kirill Tkhai
В Ср, 11/06/2014 в 12:57 +0200, Peter Zijlstra пишет: > On Wed, Jun 11, 2014 at 01:52:10PM +0400, Kirill Tkhai wrote: > > > > Currently migrate_tasks() skips throttled tasks, > > because they are not pickable by pick_next_task(). > > > > These tasks stay on dead cpu even after they > > becomes un

Re: [PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Peter Zijlstra
On Wed, Jun 11, 2014 at 01:52:10PM +0400, Kirill Tkhai wrote: > > Currently migrate_tasks() skips throttled tasks, > because they are not pickable by pick_next_task(). > > These tasks stay on dead cpu even after they > becomes unthrottled. They are not schedulable > till user manually changes the

[PATCH 1/2] sched: Rework migrate_tasks()

2014-06-11 Thread Kirill Tkhai
Currently migrate_tasks() skips throttled tasks, because they are not pickable by pick_next_task(). These tasks stay on dead cpu even after they becomes unthrottled. They are not schedulable till user manually changes their affinity or till cpu becomes alive again. But for user this looks comple