Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

2016-02-01 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> And in anycase, I guess we should be using the same logic sd.c Hannes> is using. Please see the attached patch. I'm OK with this change but please send it as a proper patch submission so somebody else can review it. -- Martin K. Petersen O

Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

2016-01-21 Thread Alexander Duyck
On Wed, Jan 20, 2016 at 11:37 PM, Hannes Reinecke wrote: > On 01/21/2016 07:35 AM, Alexander Duyck wrote: >> The patch "scsi: rescan VPD attributes" introduced a regression in which >> devices that don't support VPD were being scanned for VPD attributes >> anyway. This could cause issues for this

Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

2016-01-20 Thread Hannes Reinecke
On 01/21/2016 07:35 AM, Alexander Duyck wrote: > The patch "scsi: rescan VPD attributes" introduced a regression in which > devices that don't support VPD were being scanned for VPD attributes > anyway. This could cause issues for this parts and should be avoided so > the check for scsi_level has

[PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

2016-01-20 Thread Alexander Duyck
The patch "scsi: rescan VPD attributes" introduced a regression in which devices that don't support VPD were being scanned for VPD attributes anyway. This could cause issues for this parts and should be avoided so the check for scsi_level has been moved out of scsi_add_lun and into scsi_attach_vpd