Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-07-11 Thread Martin K. Petersen
Marcos, > Currently, all USB devices skip VPD pages, even when the device > supports them (SPC-3 and later), but some of them support VPD, like > Cruzer Blade. We'll try it and see what happens. As I mentioned, SanDisk have traditionally been pretty good wrt. spec compliance. -- Martin K. Pet

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-07-02 Thread Marcos Paulo de Souza
On Thu, Jun 20, 2019 at 04:32:38PM -0400, Martin K. Petersen wrote: > > Marcos, > > > My first idea was to add a vendor:product mapping at SCSI layer, but > > so far I haven't found one, so I added the model/vendor found by > > INQUIRY. Would it be better to check for prod:vendor (as values, > >

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-20 Thread Martin K. Petersen
Marcos, > My first idea was to add a vendor:product mapping at SCSI layer, but > so far I haven't found one, so I added the model/vendor found by > INQUIRY. Would it be better to check for prod:vendor (as values, > instead of the description)? Your patch is functionally fine. I'm just trying to

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-20 Thread Martin K. Petersen
Marcos, >> What's your confidence level wrt. all Cruzer Blades handling this >> correctly? How many devices have you tested this change with? > > I've tested three Cruzer Blades that I have at hand, and all of them > have VPD support, and also checked with a friend of mine that also > have one.

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-19 Thread Marcos Paulo de Souza
On Wed, Jun 19, 2019 at 06:45:43AM -0300, Marcos Paulo de Souza wrote: > On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote: > > > > Marcos, > > > > > Currently, all USB devices skip VPD pages, even when the device > > > supports them (SPC-3 and later), but some of them support VP

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-19 Thread Marcos Paulo de Souza
On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote: > > Marcos, > > > Currently, all USB devices skip VPD pages, even when the device > > supports them (SPC-3 and later), but some of them support VPD, like > > Cruzer Blade. > > What's your confidence level wrt. all Cruzer Blades

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-18 Thread Martin K. Petersen
Marcos, > Currently, all USB devices skip VPD pages, even when the device > supports them (SPC-3 and later), but some of them support VPD, like > Cruzer Blade. What's your confidence level wrt. all Cruzer Blades handling this correctly? How many devices have you tested this change with? -- Ma

[PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-17 Thread Marcos Paulo de Souza
Currently, all USB devices skip VPD pages, even when the device supports them (SPC-3 and later), but some of them support VPD, like Cruzer Blade. Signed-off-by: Marcos Paulo de Souza --- drivers/scsi/scsi_devinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/scsi_devinfo.c